Skip to content

Commit 53ad31c

Browse files
authored
Merge pull request #2535 from gouarin/rename-reverse-storage-iterator
rename storage_rbegin, storage_rend, ... to linear_rbegin, ...
2 parents c31e8c5 + 28b3e9c commit 53ad31c

File tree

9 files changed

+91
-91
lines changed

9 files changed

+91
-91
lines changed

include/xtensor/xcontainer.hpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -197,13 +197,13 @@ namespace xt
197197
const_linear_iterator linear_cbegin() const noexcept;
198198
const_linear_iterator linear_cend() const noexcept;
199199

200-
reverse_linear_iterator storage_rbegin() noexcept;
201-
reverse_linear_iterator storage_rend() noexcept;
200+
reverse_linear_iterator linear_rbegin() noexcept;
201+
reverse_linear_iterator linear_rend() noexcept;
202202

203-
const_reverse_linear_iterator storage_rbegin() const noexcept;
204-
const_reverse_linear_iterator storage_rend() const noexcept;
205-
const_reverse_linear_iterator storage_crbegin() const noexcept;
206-
const_reverse_linear_iterator storage_crend() const noexcept;
203+
const_reverse_linear_iterator linear_rbegin() const noexcept;
204+
const_reverse_linear_iterator linear_rend() const noexcept;
205+
const_reverse_linear_iterator linear_crbegin() const noexcept;
206+
const_reverse_linear_iterator linear_crend() const noexcept;
207207

208208
using container_iterator = linear_iterator;
209209
using const_container_iterator = const_linear_iterator;
@@ -788,37 +788,37 @@ namespace xt
788788
}
789789

790790
template <class D>
791-
inline auto xcontainer<D>::storage_rbegin() noexcept -> reverse_linear_iterator
791+
inline auto xcontainer<D>::linear_rbegin() noexcept -> reverse_linear_iterator
792792
{
793793
return storage().rbegin();
794794
}
795795

796796
template <class D>
797-
inline auto xcontainer<D>::storage_rend() noexcept -> reverse_linear_iterator
797+
inline auto xcontainer<D>::linear_rend() noexcept -> reverse_linear_iterator
798798
{
799799
return storage().rend();
800800
}
801801

802802
template <class D>
803-
inline auto xcontainer<D>::storage_rbegin() const noexcept -> const_reverse_linear_iterator
803+
inline auto xcontainer<D>::linear_rbegin() const noexcept -> const_reverse_linear_iterator
804804
{
805805
return storage().rbegin();
806806
}
807807

808808
template <class D>
809-
inline auto xcontainer<D>::storage_rend() const noexcept -> const_reverse_linear_iterator
809+
inline auto xcontainer<D>::linear_rend() const noexcept -> const_reverse_linear_iterator
810810
{
811811
return storage().rend();
812812
}
813813

814814
template <class D>
815-
inline auto xcontainer<D>::storage_crbegin() const noexcept -> const_reverse_linear_iterator
815+
inline auto xcontainer<D>::linear_crbegin() const noexcept -> const_reverse_linear_iterator
816816
{
817817
return storage().crbegin();
818818
}
819819

820820
template <class D>
821-
inline auto xcontainer<D>::storage_crend() const noexcept -> const_reverse_linear_iterator
821+
inline auto xcontainer<D>::linear_crend() const noexcept -> const_reverse_linear_iterator
822822
{
823823
return storage().crend();
824824
}

include/xtensor/xexpression.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -579,12 +579,12 @@ namespace xt
579579
XTENSOR_FORWARD_CONST_METHOD(linear_cbegin)
580580
XTENSOR_FORWARD_CONST_METHOD(linear_cend)
581581

582-
XTENSOR_FORWARD_METHOD(storage_rbegin)
583-
XTENSOR_FORWARD_METHOD(storage_rend)
584-
XTENSOR_FORWARD_CONST_METHOD(storage_rbegin)
585-
XTENSOR_FORWARD_CONST_METHOD(storage_rend)
586-
XTENSOR_FORWARD_CONST_METHOD(storage_crbegin)
587-
XTENSOR_FORWARD_CONST_METHOD(storage_crend)
582+
XTENSOR_FORWARD_METHOD(linear_rbegin)
583+
XTENSOR_FORWARD_METHOD(linear_rend)
584+
XTENSOR_FORWARD_CONST_METHOD(linear_rbegin)
585+
XTENSOR_FORWARD_CONST_METHOD(linear_rend)
586+
XTENSOR_FORWARD_CONST_METHOD(linear_crbegin)
587+
XTENSOR_FORWARD_CONST_METHOD(linear_crend)
588588

589589
template <class T = E>
590590
std::enable_if_t<has_strides<T>::value, const inner_strides_type&>

include/xtensor/xfunction.hpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,10 @@ namespace xt
297297
const_linear_iterator linear_cbegin() const noexcept;
298298
const_linear_iterator linear_cend() const noexcept;
299299

300-
const_reverse_linear_iterator storage_rbegin() const noexcept;
301-
const_reverse_linear_iterator storage_rend() const noexcept;
302-
const_reverse_linear_iterator storage_crbegin() const noexcept;
303-
const_reverse_linear_iterator storage_crend() const noexcept;
300+
const_reverse_linear_iterator linear_rbegin() const noexcept;
301+
const_reverse_linear_iterator linear_rend() const noexcept;
302+
const_reverse_linear_iterator linear_crbegin() const noexcept;
303+
const_reverse_linear_iterator linear_crend() const noexcept;
304304

305305
template <class S>
306306
const_stepper stepper_begin(const S& shape) const noexcept;
@@ -712,25 +712,25 @@ namespace xt
712712
}
713713

714714
template <class F, class... CT>
715-
inline auto xfunction<F, CT...>::storage_rbegin() const noexcept -> const_reverse_linear_iterator
715+
inline auto xfunction<F, CT...>::linear_rbegin() const noexcept -> const_reverse_linear_iterator
716716
{
717-
return storage_crbegin();
717+
return linear_crbegin();
718718
}
719719

720720
template <class F, class... CT>
721-
inline auto xfunction<F, CT...>::storage_rend() const noexcept -> const_reverse_linear_iterator
721+
inline auto xfunction<F, CT...>::linear_rend() const noexcept -> const_reverse_linear_iterator
722722
{
723-
return storage_crend();
723+
return linear_crend();
724724
}
725725

726726
template <class F, class... CT>
727-
inline auto xfunction<F, CT...>::storage_crbegin() const noexcept -> const_reverse_linear_iterator
727+
inline auto xfunction<F, CT...>::linear_crbegin() const noexcept -> const_reverse_linear_iterator
728728
{
729729
return const_reverse_linear_iterator(linear_cend());
730730
}
731731

732732
template <class F, class... CT>
733-
inline auto xfunction<F, CT...>::storage_crend() const noexcept -> const_reverse_linear_iterator
733+
inline auto xfunction<F, CT...>::linear_crend() const noexcept -> const_reverse_linear_iterator
734734
{
735735
return const_reverse_linear_iterator(linear_cbegin());
736736
}

include/xtensor/xfunctor_view.hpp

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -301,13 +301,13 @@ namespace xt
301301
const_linear_iterator linear_cbegin() const noexcept;
302302
const_linear_iterator linear_cend() const noexcept;
303303

304-
reverse_linear_iterator storage_rbegin() noexcept;
305-
reverse_linear_iterator storage_rend() noexcept;
304+
reverse_linear_iterator linear_rbegin() noexcept;
305+
reverse_linear_iterator linear_rend() noexcept;
306306

307-
const_reverse_linear_iterator storage_rbegin() const noexcept;
308-
const_reverse_linear_iterator storage_rend() const noexcept;
309-
const_reverse_linear_iterator storage_crbegin() const noexcept;
310-
const_reverse_linear_iterator storage_crend() const noexcept;
307+
const_reverse_linear_iterator linear_rbegin() const noexcept;
308+
const_reverse_linear_iterator linear_rend() const noexcept;
309+
const_reverse_linear_iterator linear_crbegin() const noexcept;
310+
const_reverse_linear_iterator linear_crend() const noexcept;
311311

312312
template <class S>
313313
stepper stepper_begin(const S& shape) noexcept;
@@ -1257,39 +1257,39 @@ namespace xt
12571257
}
12581258

12591259
template <class D>
1260-
inline auto xfunctor_applier_base<D>::storage_rbegin() noexcept -> reverse_linear_iterator
1260+
inline auto xfunctor_applier_base<D>::linear_rbegin() noexcept -> reverse_linear_iterator
12611261
{
1262-
return reverse_linear_iterator(m_e.storage_rbegin(), &m_functor);
1262+
return reverse_linear_iterator(m_e.linear_rbegin(), &m_functor);
12631263
}
12641264

12651265
template <class D>
1266-
inline auto xfunctor_applier_base<D>::storage_rend() noexcept -> reverse_linear_iterator
1266+
inline auto xfunctor_applier_base<D>::linear_rend() noexcept -> reverse_linear_iterator
12671267
{
1268-
return reverse_linear_iterator(m_e.storage_rend(), &m_functor);
1268+
return reverse_linear_iterator(m_e.linear_rend(), &m_functor);
12691269
}
12701270

12711271
template <class D>
1272-
inline auto xfunctor_applier_base<D>::storage_rbegin() const noexcept -> const_reverse_linear_iterator
1272+
inline auto xfunctor_applier_base<D>::linear_rbegin() const noexcept -> const_reverse_linear_iterator
12731273
{
1274-
return const_reverse_linear_iterator(m_e.storage_rbegin(), &m_functor);
1274+
return const_reverse_linear_iterator(m_e.linear_rbegin(), &m_functor);
12751275
}
12761276

12771277
template <class D>
1278-
inline auto xfunctor_applier_base<D>::storage_rend() const noexcept -> const_reverse_linear_iterator
1278+
inline auto xfunctor_applier_base<D>::linear_rend() const noexcept -> const_reverse_linear_iterator
12791279
{
1280-
return const_reverse_linear_iterator(m_e.storage_rend(), &m_functor);
1280+
return const_reverse_linear_iterator(m_e.linear_rend(), &m_functor);
12811281
}
12821282

12831283
template <class D>
1284-
inline auto xfunctor_applier_base<D>::storage_crbegin() const noexcept -> const_reverse_linear_iterator
1284+
inline auto xfunctor_applier_base<D>::linear_crbegin() const noexcept -> const_reverse_linear_iterator
12851285
{
1286-
return const_reverse_linear_iterator(m_e.storage_crbegin(), &m_functor);
1286+
return const_reverse_linear_iterator(m_e.linear_crbegin(), &m_functor);
12871287
}
12881288

12891289
template <class D>
1290-
inline auto xfunctor_applier_base<D>::storage_crend() const noexcept -> const_reverse_linear_iterator
1290+
inline auto xfunctor_applier_base<D>::linear_crend() const noexcept -> const_reverse_linear_iterator
12911291
{
1292-
return const_reverse_linear_iterator(m_e.storage_crend(), &m_functor);
1292+
return const_reverse_linear_iterator(m_e.linear_crend(), &m_functor);
12931293
}
12941294

12951295
/***************

include/xtensor/xiterable.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,7 +1026,7 @@ namespace xt
10261026
{
10271027
return xtl::mpl::static_if<L == static_layout>([&](auto self)
10281028
{
1029-
return self(*this).derived_cast().storage_rbegin();
1029+
return self(*this).derived_cast().linear_rbegin();
10301030
}, /*else*/ [&](auto self)
10311031
{
10321032
return self(*this).iterable_base::template rbegin<L>();
@@ -1044,7 +1044,7 @@ namespace xt
10441044
{
10451045
return xtl::mpl::static_if<L == static_layout>([&](auto self)
10461046
{
1047-
return self(*this).derived_cast().storage_rend();
1047+
return self(*this).derived_cast().linear_rend();
10481048
}, /*else*/ [&](auto self)
10491049
{
10501050
return self(*this).iterable_base::template rend<L>();
@@ -1085,7 +1085,7 @@ namespace xt
10851085
{
10861086
return xtl::mpl::static_if<L == static_layout>([&](auto self)
10871087
{
1088-
return self(*this).derived_cast().storage_crbegin();
1088+
return self(*this).derived_cast().linear_crbegin();
10891089
}, /*else*/ [&](auto self)
10901090
{
10911091
return self(*this).iterable_base::template crbegin<L>();
@@ -1103,7 +1103,7 @@ namespace xt
11031103
{
11041104
return xtl::mpl::static_if<L == static_layout>([&](auto self)
11051105
{
1106-
return self(*this).derived_cast().storage_crend();
1106+
return self(*this).derived_cast().linear_crend();
11071107
}, /*else*/ [&](auto self)
11081108
{
11091109
return self(*this).iterable_base::template crend<L>();

include/xtensor/xoptional_assembly_base.hpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,13 @@ namespace xt
224224
const_linear_iterator linear_cbegin() const noexcept;
225225
const_linear_iterator linear_cend() const noexcept;
226226

227-
reverse_linear_iterator storage_rbegin() noexcept;
228-
reverse_linear_iterator storage_rend() noexcept;
227+
reverse_linear_iterator linear_rbegin() noexcept;
228+
reverse_linear_iterator linear_rend() noexcept;
229229

230-
const_reverse_linear_iterator storage_rbegin() const noexcept;
231-
const_reverse_linear_iterator storage_rend() const noexcept;
232-
const_reverse_linear_iterator storage_crbegin() const noexcept;
233-
const_reverse_linear_iterator storage_crend() const noexcept;
230+
const_reverse_linear_iterator linear_rbegin() const noexcept;
231+
const_reverse_linear_iterator linear_rend() const noexcept;
232+
const_reverse_linear_iterator linear_crbegin() const noexcept;
233+
const_reverse_linear_iterator linear_crend() const noexcept;
234234

235235
template <class S>
236236
stepper stepper_begin(const S& shape) noexcept;
@@ -869,37 +869,37 @@ namespace xt
869869
}
870870

871871
template <class D>
872-
inline auto xoptional_assembly_base<D>::storage_rbegin() noexcept -> reverse_linear_iterator
872+
inline auto xoptional_assembly_base<D>::linear_rbegin() noexcept -> reverse_linear_iterator
873873
{
874874
return reverse_linear_iterator(linear_end());
875875
}
876876

877877
template <class D>
878-
inline auto xoptional_assembly_base<D>::storage_rend() noexcept -> reverse_linear_iterator
878+
inline auto xoptional_assembly_base<D>::linear_rend() noexcept -> reverse_linear_iterator
879879
{
880880
return reverse_linear_iterator(linear_begin());
881881
}
882882

883883
template <class D>
884-
inline auto xoptional_assembly_base<D>::storage_rbegin() const noexcept -> const_reverse_linear_iterator
884+
inline auto xoptional_assembly_base<D>::linear_rbegin() const noexcept -> const_reverse_linear_iterator
885885
{
886-
return storage_crbegin();
886+
return linear_crbegin();
887887
}
888888

889889
template <class D>
890-
inline auto xoptional_assembly_base<D>::storage_rend() const noexcept -> const_reverse_linear_iterator
890+
inline auto xoptional_assembly_base<D>::linear_rend() const noexcept -> const_reverse_linear_iterator
891891
{
892-
return storage_crend();
892+
return linear_crend();
893893
}
894894

895895
template <class D>
896-
inline auto xoptional_assembly_base<D>::storage_crbegin() const noexcept -> const_reverse_linear_iterator
896+
inline auto xoptional_assembly_base<D>::linear_crbegin() const noexcept -> const_reverse_linear_iterator
897897
{
898898
return const_reverse_linear_iterator(linear_cend());
899899
}
900900

901901
template <class D>
902-
inline auto xoptional_assembly_base<D>::storage_crend() const noexcept -> const_reverse_linear_iterator
902+
inline auto xoptional_assembly_base<D>::linear_crend() const noexcept -> const_reverse_linear_iterator
903903
{
904904
return const_reverse_linear_iterator(linear_cbegin());
905905
}

include/xtensor/xscalar.hpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -256,13 +256,13 @@ namespace xt
256256
const_iterator linear_cbegin() const noexcept;
257257
const_iterator linear_cend() const noexcept;
258258

259-
reverse_iterator storage_rbegin() noexcept;
260-
reverse_iterator storage_rend() noexcept;
259+
reverse_iterator linear_rbegin() noexcept;
260+
reverse_iterator linear_rend() noexcept;
261261

262-
const_reverse_iterator storage_rbegin() const noexcept;
263-
const_reverse_iterator storage_rend() const noexcept;
264-
const_reverse_iterator storage_crbegin() const noexcept;
265-
const_reverse_iterator storage_crend() const noexcept;
262+
const_reverse_iterator linear_rbegin() const noexcept;
263+
const_reverse_iterator linear_rend() const noexcept;
264+
const_reverse_iterator linear_crbegin() const noexcept;
265+
const_reverse_iterator linear_crend() const noexcept;
266266

267267
template <class S>
268268
stepper stepper_begin(const S& shape) noexcept;
@@ -838,37 +838,37 @@ namespace xt
838838
}
839839

840840
template <class CT>
841-
inline auto xscalar<CT>::storage_rbegin() noexcept -> reverse_iterator
841+
inline auto xscalar<CT>::linear_rbegin() noexcept -> reverse_iterator
842842
{
843843
return this->template rbegin<XTENSOR_DEFAULT_LAYOUT>();
844844
}
845845

846846
template <class CT>
847-
inline auto xscalar<CT>::storage_rend() noexcept -> reverse_iterator
847+
inline auto xscalar<CT>::linear_rend() noexcept -> reverse_iterator
848848
{
849849
return this->template rend<XTENSOR_DEFAULT_LAYOUT>();
850850
}
851851

852852
template <class CT>
853-
inline auto xscalar<CT>::storage_rbegin() const noexcept -> const_reverse_iterator
853+
inline auto xscalar<CT>::linear_rbegin() const noexcept -> const_reverse_iterator
854854
{
855855
return this->template rbegin<XTENSOR_DEFAULT_LAYOUT>();
856856
}
857857

858858
template <class CT>
859-
inline auto xscalar<CT>::storage_rend() const noexcept -> const_reverse_iterator
859+
inline auto xscalar<CT>::linear_rend() const noexcept -> const_reverse_iterator
860860
{
861861
return this->template rend<XTENSOR_DEFAULT_LAYOUT>();
862862
}
863863

864864
template <class CT>
865-
inline auto xscalar<CT>::storage_crbegin() const noexcept -> const_reverse_iterator
865+
inline auto xscalar<CT>::linear_crbegin() const noexcept -> const_reverse_iterator
866866
{
867867
return this->template crbegin<XTENSOR_DEFAULT_LAYOUT>();
868868
}
869869

870870
template <class CT>
871-
inline auto xscalar<CT>::storage_crend() const noexcept -> const_reverse_iterator
871+
inline auto xscalar<CT>::linear_crend() const noexcept -> const_reverse_iterator
872872
{
873873
return this->template crend<XTENSOR_DEFAULT_LAYOUT>();
874874
}

0 commit comments

Comments
 (0)