Add retry measurements dialog window#266
Merged
roussel-ryan merged 2 commits intoJun 9, 2026
Merged
Conversation
nstelter-slac
changed the title
nstelter-slac
force-pushed
the
retry_measurement_dialog
branch
2 times, most recently
from
6850f26 to
7c2d97e
Compare
Collaborator
Author
|
also tested manually by making |
nstelter-slac
force-pushed
the
retry_measurement_dialog
branch
2 times, most recently
from
63babaa to
81df8fe
Compare
…are errors in setting variable values / getting observables from the environment Adds a `dialog_action_queue` to communicate the error and dialog-slection between core-subprocess and routine.
nstelter-slac
force-pushed
the
retry_measurement_dialog
branch
from
81df8fe to
c4946fc
Compare
add styled accept/deny icons to window buttons (matches the settings window), and allow for traceback text to display in readable way.
Collaborator
Author
|
updated measurements dialog window looks like this: |
roussel-ryan
approved these changes
Jun 9, 2026
Collaborator
Author
|
will (sooner than) later look into using existing class for dialog window traceback display |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dialog window that allows users to retry measurements when there are errors in setting variable values / getting observables from the environment
this is an edit ontop of #263 (and 263 can be closed), since couldn't figure out how to push to that PR since its on the 'copilot' user's fork