Add retry/abort measurement dialog for environment evaluation failures#263
Draft
Copilot wants to merge 4 commits into
Draft
Add retry/abort measurement dialog for environment evaluation failures#263Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/1472982c-183f-421a-af38-8f4c31ed6690 Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/1472982c-183f-421a-af38-8f4c31ed6690 Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/1472982c-183f-421a-af38-8f4c31ed6690 Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
roussel-ryan
May 14, 2026 20:55
View session
Collaborator
|
@copilot add in a test to make sure the dialog works in the broader Badger application |
Agent-Logs-Url: https://github.com/xopt-org/Badger/sessions/caca210a-2a67-4e39-b049-dcd441cb4ee2 Co-authored-by: roussel-ryan <24279776+roussel-ryan@users.noreply.github.com>
Author
Added a broader Badger application-level test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When a run hit transient failures while setting variables or reading observables, the subprocess surfaced a hard error and terminated the run. This change introduces an explicit operator decision point so failed measurements can be retried in-place instead of forcing immediate termination.
Subprocess: retry-aware measurement loop
evaluate_measurement_with_retry(...)incore_subprocess.py.retry/abort).BadgerRunTerminatedwith failure context from the original measurement exception.GUI runner: operator action path
BadgerRoutineSubprocess.check_queue()to detect structured measurement error messages.retry) or stop (abort) execution.New dialog: focused recovery UX
BadgerMeasurementRetryDialogwith:Dialog tests
test_measurement_retry_dialog.pyto cover retry/stop actions and verify rendered summary/details content.test_gui_basic.pythat verifies the retry dialog path is invoked from the routine runner queue handling and that the retry action is sent back to the subprocess channel.