From 3866a47930fe35943672258ffa619f1bc9092716 Mon Sep 17 00:00:00 2001 From: Doga Gursoy Date: Tue, 2 Jun 2026 22:48:00 +0300 Subject: [PATCH] fix(arch): extend slice-verb fitness allowlist for Agent's event + reaction domain nouns MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #22 (slice-a-reaction-split, commit 935780130) landed the `agent.dismiss_event_in_reaction` operator slice without extending the Phase 5 slice-verb fitness allowlist. The slice uses two real Agent-BC domain nouns: - `Reaction` is the Agent BC's term for subscriber classes (RunDebriefer, CautionDrafter) — they react to events from other BCs. See the slice's command.py docstring for the full "Reaction's bookmark" framing. - `event` is the unit the Reaction processes; the operator-recovery slice advances the bookmark past a poison event. Adds both to `_DOMAIN_NOUN_ALLOWLIST` in test_slice_verb_names_subject.py with the same per-entry comment style as the existing reasoning / entry / permission entries. Origin/main's `test_slice_dir_carries_subject` was failing post-PR-#22 merge; this fix unblocks ANY downstream PR built on origin/main. --- apps/api/tests/architecture/test_slice_verb_names_subject.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/api/tests/architecture/test_slice_verb_names_subject.py b/apps/api/tests/architecture/test_slice_verb_names_subject.py index 81b55ddf5..41f2e87d8 100644 --- a/apps/api/tests/architecture/test_slice_verb_names_subject.py +++ b/apps/api/tests/architecture/test_slice_verb_names_subject.py @@ -79,6 +79,8 @@ "reasoning", # Decision: append_reasoning_entries "entry", # Decision: append_reasoning_entries (plural-stripped) "permission", # Trust: list_permissions + "event", # Agent: dismiss_event_in_reaction + "reaction", # Agent: dismiss_event_in_reaction (Reaction = subscriber class) } )