[WIP] Find everywhere Json is written to the log

* Get rid of operator<<(std::ostream&, const Value& root), and
  fix everything that breaks.

Author: ximinez

include/xrpl/json/json_writer.h

@@ -211,8 +211,8 @@ valueToQuotedString(const char* value);
 
 /// \brief Output using the StyledStreamWriter.
 /// \see Json::operator>>()
-std::ostream&
-operator<<(std::ostream&, const Value& root);
+// std::ostream&
+// operator<<(std::ostream&, const Value& root);
 
 //------------------------------------------------------------------------------
 

include/xrpl/json/to_string.h

@@ -35,9 +35,9 @@ to_string(Value const&);
 std::string
 pretty(Value const&);
 
-/** Output using the StyledStreamWriter. @see Json::operator>>(). */
-std::ostream&
-operator<<(std::ostream&, const Value& root);
+///** Output using the StyledStreamWriter. @see Json::operator>>(). */
+// std::ostream&
+// operator<<(std::ostream&, const Value& root);
 
 }  // namespace Json
 

include/xrpl/protocol/STBase.h

@@ -157,7 +157,8 @@ class STBase
     virtual std::string
     getText() const;
 
-    virtual Json::Value getJson(JsonOptions /*options*/) const;
+    virtual Json::Value getJson(
+        JsonOptions = JsonOptions::none /*options*/) const;
 
     virtual void
     add(Serializer& s) const;

include/xrpl/protocol/STValidation.h

@@ -22,6 +22,7 @@
 
 #include <xrpl/basics/Log.h>
 #include <xrpl/beast/utility/instrumentation.h>
+#include <xrpl/json/to_string.h>
 #include <xrpl/protocol/FeeUnits.h>
 #include <xrpl/protocol/PublicKey.h>
 #include <xrpl/protocol/STObject.h>
@@ -190,7 +191,7 @@ STValidation::STValidation(
     if (checkSignature && !isValid())
     {
         JLOG(debugLog().error()) << "Invalid signature in validation: "
-                                 << getJson(JsonOptions::none);
+                                 << to_string(getJson(JsonOptions::none));
         Throw<std::runtime_error>("Invalid signature in validation");
     }
 

src/test/app/NFTokenBurn_test.cpp

@@ -416,7 +416,7 @@ class NFTokenBurnBaseUtil_test : public beast::unit_test::suite
                 Json::Value jrr = env.rpc(
                     "json",
                     "ledger_data",
-                    boost::lexical_cast<std::string>(jvParams));
+                    boost::lexical_cast<std::string>(to_string(jvParams)));
 
                 Json::Value& state = jrr[jss::result][jss::state];
 
@@ -463,7 +463,7 @@ class NFTokenBurnBaseUtil_test : public beast::unit_test::suite
                 Json::Value jrr = env.rpc(
                     "json",
                     "ledger_data",
-                    boost::lexical_cast<std::string>(jvParams));
+                    boost::lexical_cast<std::string>(to_string(jvParams)));
 
                 Json::Value& state = jrr[jss::result][jss::state];
 

src/test/app/NFTokenDir_test.cpp

@@ -50,7 +50,7 @@ class NFTokenDir_test : public beast::unit_test::suite
             Json::Value jrr = env.rpc(
                 "json",
                 "ledger_data",
-                boost::lexical_cast<std::string>(jvParams));
+                boost::lexical_cast<std::string>(to_string(jvParams)));
 
             // Iterate the state and print all NFTokenPages.
             if (!jrr.isMember(jss::result) ||

src/test/app/Oracle_test.cpp

@@ -19,6 +19,7 @@
 
 #include <test/jtx/Oracle.h>
 
+#include <xrpl/json/to_string.h>
 #include <xrpl/protocol/jss.h>
 
 namespace ripple {
@@ -580,10 +581,8 @@ struct Oracle_test : public beast::unit_test::suite
                 jvParams[field] = value;
                 jvParams[jss::binary] = false;
                 jvParams[jss::type] = jss::oracle;
-                Json::Value jrr = env.rpc(
-                    "json",
-                    "ledger_data",
-                    boost::lexical_cast<std::string>(jvParams));
+                Json::Value jrr =
+                    env.rpc("json", "ledger_data", to_string(jvParams));
                 BEAST_EXPECT(jrr[jss::result][jss::state].size() == 2);
             };
             verifyLedgerData(jss::ledger_index, index);

src/test/json/json_value_test.cpp

@@ -22,6 +22,7 @@
 #include <xrpl/json/json_reader.h>
 #include <xrpl/json/json_value.h>
 #include <xrpl/json/json_writer.h>
+#include <xrpl/json/to_string.h>
 
 #include <algorithm>
 #include <regex>
@@ -833,7 +834,8 @@ struct json_value_test : beast::unit_test::suite
         BEAST_EXPECT(r.parse(s, j));
         {
             std::stringstream ss;
-            ss << j;
+            // UNDO
+            ss << pretty(j);
             BEAST_EXPECT(countLines(ss.str()) > 1);
         }
         {

src/test/jtx/TestSuite.h

@@ -21,6 +21,7 @@
 #define RIPPLE_BASICS_TESTSUITE_H_INCLUDED
 
 #include <xrpl/beast/unit_test.h>
+#include <xrpl/json/to_string.h>
 
 #include <string>
 

src/test/jtx/impl/Env.cpp

@@ -355,7 +355,7 @@ Env::sign_and_submit(JTx const& jt, Json::Value params)
     if (params.isNull())
     {
         // Use the command line interface
-        auto const jv = boost::lexical_cast<std::string>(jt.jv);
+        auto const jv = boost::lexical_cast<std::string>(to_string(jt.jv));
         jr = rpc("submit", passphrase, jv);
     }
     else