FIX | proxy bug #4

Author: xiadnoring

main.cpp

@@ -211,7 +211,9 @@ int main () {
 
         router.GET ("/fetch", [&a] (manapi::net::http::request &req, manapi::net::http::response *resp)
             -> void {
-            resp->proxy("https://www.wikipedia.org").unwrap();
+            resp->proxy("https://www.wikipedia.org", [] (manapi::net::fetch &n) -> void {
+                n.verbose(true);
+            }).unwrap();
             resp->finish();
         }).unwrap();
 

src/services/ManapiFetch.cpp

@@ -1286,8 +1286,11 @@ manapi::error::status manapi::net::fetch::headers(std::map<std::string, std::str
     {
         try {
             auto val = std::make_pair<std::string_view, std::string_view>(header.first, header.second);
-            char data[http::stringify_header_size(val)];
+            auto const ss = http::stringify_header_size(val);
+            char data[ss + 1];
             auto hv = manapi::net::http::stringify_header(data, val);
+            assert(ss == hv);
+            data[ss]='\0';
             this->data->curl_headers.reset(curl_slist_append(this->data->curl_headers.release(), data));
             if (!this->data->curl_headers)
                 return manapi::error::status_resource_exhausted();
@@ -1305,8 +1308,11 @@ manapi::error::status manapi::net::fetch::header_(std::string_view key, std::str
 
     try {
         auto val = std::make_pair(key, value);
-        char data[http::stringify_header_size(val)];
+        auto const ss = http::stringify_header_size(val);
+        char data[ss + 1];
         auto hv = manapi::net::http::stringify_header(data, val);
+        assert(ss==hv);
+        data[hv] = '\0';
         this->data->curl_headers.reset(curl_slist_append(this->data->curl_headers.release(), data));
         if (!this->data->curl_headers)
             return manapi::error::status_resource_exhausted();
@@ -1354,9 +1360,11 @@ manapi::error::status manapi::net::fetch::json_headers(manapi::json headers) MAN
             }
             auto val = std::make_pair<std::string_view, std::string_view>(header.first, {});
             val.second = val_view;
-
-            char data[http::stringify_header_size(val)];
+            auto const ss = http::stringify_header_size(val);
+            char data[ss + 1];
             auto hv = manapi::net::http::stringify_header(data, val);
+            assert(ss==hv);
+            data[ss] = '\0';
             this->data->curl_headers.reset(curl_slist_append(this->data->curl_headers.release(), data));
         }
         catch (std::exception const &e) {