Skip to content

Commit d4203ab

Browse files
xenOs76xenOs76
committed
refactor: test loops using t.Parallel() to import a local copy of the test case variable
1 parent 0e46054 commit d4203ab

1 file changed

Lines changed: 42 additions & 21 deletions

File tree

‎internal/requests/requests_test.go‎

Lines changed: 42 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ func TestNewRequestsMetaConfig(t *testing.T) {
5252
func TestRequestsMetaConfig_SetVerbose(t *testing.T) {
5353
tests := []bool{true, false}
5454

55-
for _, tt := range tests {
55+
for _, tc := range tests {
56+
tt := tc // safer when using t.Parallel()
5657
testname := fmt.Sprintf("SetVerbose(%v)", tt)
5758
t.Run(testname, func(t *testing.T) {
5859
t.Parallel()
@@ -67,7 +68,8 @@ func TestRequestsMetaConfig_SetVerbose(t *testing.T) {
6768
func TestRequestsMetaConfig_SetDebug(t *testing.T) {
6869
tests := []bool{true, false}
6970

70-
for _, tt := range tests {
71+
for _, tc := range tests {
72+
tt := tc // safer when using t.Parallel()
7173
testname := fmt.Sprintf("SetDebug(%v)", tt)
7274
t.Run(testname, func(t *testing.T) {
7375
t.Parallel()
@@ -92,7 +94,8 @@ func TestRequestsMetaConfig_SetCaPoolFromYAML(t *testing.T) {
9294
},
9395
}
9496

95-
for _, tt := range tests {
97+
for _, tc := range tests {
98+
tt := tc // safer when using t.Parallel()
9699
testname := fmt.Sprintf("SetCaPoolFromYAML(%v)", tt.desc)
97100
t.Run(testname, func(t *testing.T) {
98101
t.Parallel()
@@ -137,7 +140,8 @@ func TestRequestsMetaConfig_SetCaPoolFromFile(t *testing.T) {
137140
},
138141
}
139142

140-
for _, tt := range tests {
143+
for _, tc := range tests {
144+
tt := tc // safer when using t.Parallel()
141145
testname := fmt.Sprintf("SetCaPoolFromFile(%v)", tt.desc)
142146
t.Run(testname, func(t *testing.T) {
143147
t.Parallel()
@@ -180,7 +184,8 @@ func TestRequestsMetaConfig_SetRequests(t *testing.T) {
180184

181185
tests := [][]RequestConfig{requestConfigs}
182186

183-
for _, tt := range tests {
187+
for _, tc := range tests {
188+
tt := tc // use a local copy of tc should be safer when using t.Parallel()
184189
testname := fmt.Sprintf("SetRequests(%v)", tt[0].Name)
185190
t.Run(testname, func(t *testing.T) {
186191
t.Parallel()
@@ -264,7 +269,8 @@ func TestNewHTTPClientFromRequestConfig_Error(t *testing.T) {
264269
},
265270
}
266271

267-
for _, tt := range tests {
272+
for _, tc := range tests {
273+
tt := tc // safer when using t.Parallel()
268274
t.Run(tt.desc, func(t *testing.T) {
269275
t.Parallel()
270276

@@ -322,7 +328,8 @@ func TestNewHTTPClientFromRequestConfig(t *testing.T) {
322328
},
323329
}
324330

325-
for _, tt := range tests {
331+
for _, tc := range tests {
332+
tt := tc // safer when using t.Parallel()
326333
t.Run(tt.desc, func(t *testing.T) {
327334
t.Parallel()
328335

@@ -403,7 +410,8 @@ func TestNewRequestHTTPClient_SetServerName(t *testing.T) {
403410
" a silly string ",
404411
}
405412

406-
for _, tt := range tests {
413+
for _, tc := range tests {
414+
tt := tc // safer when using t.Parallel()
407415
testname := fmt.Sprintf("%v", tt)
408416
t.Run(testname, func(t *testing.T) {
409417
t.Parallel()
@@ -453,7 +461,8 @@ func TestNewRequestHTTPClient_SetServerName_Error(t *testing.T) {
453461
},
454462
}
455463

456-
for _, tt := range testsError {
464+
for _, tc := range testsError {
465+
tt := tc // safer when using t.Parallel()
457466
t.Run(tt.desc, func(t *testing.T) {
458467
t.Parallel()
459468

@@ -483,7 +492,8 @@ func TestNewRequestHTTPClient_SetClientTimeout(t *testing.T) {
483492
3, 0, 50,
484493
}
485494

486-
for _, tt := range tests {
495+
for _, tc := range tests {
496+
tt := tc // safer when using t.Parallel()
487497
testname := fmt.Sprintf("%v", tt)
488498
t.Run(testname, func(t *testing.T) {
489499
t.Parallel()
@@ -550,7 +560,8 @@ func TestNewRequestHTTPClient_SetCaCertsPool(t *testing.T) {
550560
{"System Cert Pool", defaultCertPool, defaultCertPool},
551561
}
552562

553-
for _, tt := range tests {
563+
for _, tc := range tests {
564+
tt := tc // safer when using t.Parallel()
554565
t.Run(tt.testname, func(t *testing.T) {
555566
t.Parallel()
556567

@@ -576,7 +587,8 @@ func TestNewRequestHTTPClient_SetCaCertsPool(t *testing.T) {
576587

577588
func TestNewRequestHTTPClient_SetInsecureSkipVerify_struct(t *testing.T) {
578589
tests := []bool{true, false}
579-
for _, tt := range tests {
590+
for _, tc := range tests {
591+
tt := tc // safer when using t.Parallel()
580592
testname := fmt.Sprintf("%v", tt)
581593

582594
t.Run(testname, func(t *testing.T) {
@@ -605,7 +617,8 @@ func TestNewRequestHTTPClient_SetInsecureSkipVerify_struct(t *testing.T) {
605617

606618
func TestNewRequestHTTPClient_SetInsecureSkipVerify_tlsServer(t *testing.T) {
607619
tests := []bool{true, false}
608-
for _, tt := range tests {
620+
for _, tc := range tests {
621+
tt := tc // safer when using t.Parallel()
609622
testname := fmt.Sprintf("%v", tt)
610623

611624
t.Run(testname, func(t *testing.T) {
@@ -653,7 +666,8 @@ func TestNewRequestHTTPClient_SetMethod(t *testing.T) {
653666
{"post", http.MethodPost},
654667
}
655668

656-
for _, tt := range tests {
669+
for _, tc := range tests {
670+
tt := tc // safer when using t.Parallel()
657671
testname := fmt.Sprintf("%v", tt.got)
658672

659673
t.Run(testname, func(t *testing.T) {
@@ -679,7 +693,8 @@ func TestRequestHTTPClient_SetTransportOverride_transportAddress_struc(t *testin
679693
{"https://example.com", "example.com:443"},
680694
}
681695

682-
for _, tt := range tests {
696+
for _, tc := range tests {
697+
tt := tc // safer when using t.Parallel()
683698
testname := fmt.Sprintf("%v", tt.got)
684699
t.Run(testname, func(t *testing.T) {
685700
t.Parallel()
@@ -716,7 +731,8 @@ func TestRequestHTTPClient_SetTransportOverride_transportAddress_server(t *testi
716731
},
717732
}
718733

719-
for _, tt := range tests {
734+
for _, tc := range tests {
735+
tt := tc // safer when using t.Parallel()
720736
testname := fmt.Sprintf("%v", tt.trasportURL)
721737
t.Run(testname, func(t *testing.T) {
722738
t.Parallel()
@@ -812,7 +828,8 @@ func TestRequestHTTPClient_SetProxyProtocolV2_server(t *testing.T) {
812828
},
813829
}
814830

815-
for _, tt := range tests {
831+
for _, tc := range tests {
832+
tt := tc // safer when using t.Parallel()
816833
t.Run(tt.testname, func(t *testing.T) {
817834
t.Parallel()
818835

@@ -898,7 +915,8 @@ func TestRequestHTTPClient_SetProxyProtocolV2_server(t *testing.T) {
898915
func TestPrintCmd(t *testing.T) {
899916
tests := []bool{true, false}
900917

901-
for _, tt := range tests {
918+
for _, tc := range tests {
919+
tt := tc // safer when using t.Parallel()
902920
testname := fmt.Sprintf("%v", tt)
903921
t.Run(testname, func(t *testing.T) {
904922
t.Parallel()
@@ -950,7 +968,8 @@ func TestPrintResponseDebug(t *testing.T) {
950968
},
951969
}
952970

953-
for _, tt := range tests {
971+
for _, tc := range tests {
972+
tt := tc // safer when using t.Parallel()
954973
t.Run(tt.desc, func(t *testing.T) {
955974
t.Parallel()
956975

@@ -1080,7 +1099,8 @@ func TestPrintRequestDebug(t *testing.T) {
10801099
},
10811100
}
10821101

1083-
for _, tt := range tests {
1102+
for _, tc := range tests {
1103+
tt := tc // safer when using t.Parallel()
10841104
t.Run(tt.desc, func(t *testing.T) {
10851105
t.Parallel()
10861106

@@ -1163,7 +1183,8 @@ func TestProcessHTTPRequestsByHost(t *testing.T) {
11631183
},
11641184
}
11651185

1166-
for _, tt := range tests {
1186+
for _, tc := range tests {
1187+
tt := tc // safer when using t.Parallel()
11671188
t.Run(tt.reqConf.Name, func(t *testing.T) {
11681189
t.Parallel()
11691190

0 commit comments

Comments
 (0)