Skip to content

[script.easytv] 1.5.2#2824

Open
Rouzax wants to merge 1 commit into
xbmc:omegafrom
Rouzax:omega-script-easytv
Open

[script.easytv] 1.5.2#2824
Rouzax wants to merge 1 commit into
xbmc:omegafrom
Rouzax:omega-script-easytv

Conversation

@Rouzax
Copy link
Copy Markdown

@Rouzax Rouzax commented May 5, 2026

Update: EasyTV v1.5.2

Addon ID: script.easytv
Version: 1.5.2
Previous version: 1.5.1

Changes since 1.5.1

This update consolidates six 1.5.2~alpha development releases plus a small set of stable-polish fixes. The changes break down as follows:

Multi-instance sync hardening (1.5.2~alpha1 through alpha4):

  • Cross-instance updates (new episodes, fully-watched shows, resume progress) now appear in Browse mode and random playlists without requiring a local library scan
  • Clone addons now correctly load script.module.pymysql and connect read-only to the shared sync database advertised by the main service. Existing clones will prompt for a mandatory update on next launch.
  • Clones can no longer accidentally clear the main service's advertised database configuration when their connection attempt fails
  • Fixed duplicate primary-key error during show ID validation at service startup when stale entries shared title + year with valid rows
  • "Skip premieres" filter no longer hides in-progress E01 episodes (e.g. resume point synced from another instance), consistent with how smart playlists already handle partially-watched premieres

Browse-view art reliability (1.5.2~alpha5):

  • Show posters and fanart no longer disappear permanently when the first per-Kodi-session art fetch returns an empty or partial JSON-RPC result. The session art-fetch flag now self-heals on each addon launch and is only set when at least one show actually had a non-empty poster. Reported in No images displayed of any TV series in any view Rouzax/script.easytv#2.

Dialog UX redesign (1.5.2~alpha6):

  • Next-episode prompt rebuilt with two-block copy ("You just watched [show SxxEyy]" / "Up next [SxxEyy title]"), bold-formatted titles, "Watch Next" / "Skip" buttons, and a slightly taller 800x490 dialog so the multi-line message and subtitle fit without crowding. Mirrors the EasyMovie sibling addon's continuation pattern.
  • Missed-episode warning rephrased and reformatted: episode identifier now uses Kodi-standard SxxEyy format instead of the previous (06x02) bracketed form, and the dialog text gained an "instead?" framing so the swap-to-library-version semantics is explicit.

Stable polish (1.5.2):

  • "Now Playing" notification no longer truncates show titles that contain commas (e.g. "What We Do, In the Shadows"). Switched from xbmc.executebuiltin('Notification(...)') (comma-separated argument parsing) to the typed xbmcgui.Dialog().notification API.
  • Prompt timeout (seconds) help text corrected: now says "Set to 0 for no automatic dismissal" instead of the inaccurate "Maximum (60) waits indefinitely". Code behaviour was always 0 = indefinite.
  • Documentation site rebuilt page by page (excluded from this submission; lives at https://rouzax.github.io/script.easytv/docs/).

Internal

  • Service clears advertised DB config on shutdown, DB failure, and when multi-instance sync is disabled.
  • Diagnostic logging added for premiere filter (before/after counts), storage backend selection in clones, and shared DB sync skip reasons.
  • New tests exercise the real import pymysql code path via sys.modules manipulation. Previous clone-fallback tests mocked SharedDatabase.is_available() directly, which hid two clone bugs (above) by never executing the failing import or the state-clearing side effect.

Technical details

  • Python 3.8+ compatible (Kodi 21 Omega and newer)
  • Depends on xbmc.python 3.0.1 and script.module.pymysql 1.1.0
  • Passes pyright, pyflakes, and kodi-addon-checker with no errors
  • Sibling addon to script.easymovie

Links

@kodiai
Copy link
Copy Markdown

kodiai Bot commented May 5, 2026

Kodiai Addon Check

Addon Level Message
script.easytv WARN 403 Client Error: Forbidden for url: https://forum.kodi.tv/showthread.php?tid=383902
script.easytv WARN We found no problems and 1 warnings, please check the logfile.

0 error(s), 2 warning(s) found.

@kodiai
Copy link
Copy Markdown

kodiai Bot commented May 5, 2026

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 50 changed files.
Review Details
  • Files reviewed: 59

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +1995 -427

  • Requested profile: minimal (auto, lines changed: 2422)

  • Effective profile: minimal

  • Bounded review: covered 50/59 changed files via large-PR triage (30 full, 20 abbreviated; 9 not reviewed)

  • Contributor experience: coarse-fallback (using coarse fallback signals only)

  • Review completed: 2026-05-05T09:01:55.132Z

  • Total wall-clock: 3m 32s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 2.4s
    • retrieval/context assembly: 3.5s
    • executor handoff: 15s
    • remote runtime: 3m 6s
    • publication: 3.0s
  • Claude Code usage: 2% of seven_day limit remaining | resets 2026-05-06T02:00:00.000Z

  • Tokens: 78 in / 6,364 out | 0.7147

  • Review scope: Reviewed 50/59 files, prioritized by risk

  • Full review: 30 files | Abbreviated review: 20 files | Not reviewed: 9 files

Files not fully reviewed (sorted by risk score)
  • script.easytv/icon.png (risk: 26)
  • script.easytv/icon_default.png (risk: 26)
  • script.easytv/resources/icons/icon-ember.png (risk: 26)
  • script.easytv/resources/icons/icon-golden-hour.png (risk: 26)
  • script.easytv/resources/icons/icon-nightfall.png (risk: 26)
  • script.easytv/resources/icons/icon-ultraviolet.png (risk: 26)
  • script.easytv/resources/skins/Default/media/IconMovieSet.png (risk: 26)
  • script.easytv/resources/skins/Default/media/IconWatched.png (risk: 26)
  • script.easytv/resources/skins/Default/media/common/scrim_topleft.png (risk: 26)
- Keyword parsing: No keywords detected
  • Keyword parsing: No keywords detected

@romanvm romanvm added the Don't Merge Do not merge this PR label May 18, 2026
@romanvm
Copy link
Copy Markdown

romanvm commented May 18, 2026

As I said in my other comment, we cannot allow addon cloning mechanism in the official repo.

@Rouzax
Copy link
Copy Markdown
Author

Rouzax commented May 19, 2026

@romanvm Thank you for the update, and for taking the time to discuss this internally and provide a clear answer.

Cloning is a core feature of EasyTV that I'm not willing to remove, so I'll continue distributing through my own repository. Please go ahead with removing EasyTV from the official repo whenever you're ready.

I'd still like to confirm: am I free to continue using this forum thread to support users and post updates?

Thanks again to everyone who reviewed the submissions and engaged with the discussion.

@Rouzax
Copy link
Copy Markdown
Author

Rouzax commented May 19, 2026

@romanvm Thank you for the update, and for providing a clear answer.

Cloning is a core feature of EasyTV that I'm not willing to remove, so I'll continue distributing through my own repository. Please go ahead with removing EasyTV from the official repo whenever you're ready.

I'd still like to confirm: am I free to continue using this forum thread to support users and post updates?

Thanks again to everyone who reviewed the submissions and engaged with the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Don't Merge Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants