Really great project overall. I am really glad to see how much you've learned about this very complex subject in just one week.
Some things I noted:
- In this endpoint: /NFT/bal/:address, you call .setRocketTokenAddress. What is the reason for that? This involve doing a transaction every time we want to simply get the balance. In fact it would have been much simpler to just call the balanceOf method of the Rocket Token, rather than having a custom method in the NFT contract. P.S.: I now see that you do exactly this in another endpoint, so is it just a leftover?
- This endpoint "/NFT/mint/:address" shouldn't exist. It makes it way too easy for anyone to get a free NFT. The safeMint method should also be restricted in your contract, as anybody can call it.
- I didn't find an endpoint for the Check if an address has approved the NFT contract to transfer at least 1 Rocket Token asked in the requirements?
- Same for this Get the metadata of a token
That's mostly it. I really liked the way you used the npm commands to implement your functionalities. Clean project as well. Congrats!
Really great project overall. I am really glad to see how much you've learned about this very complex subject in just one week.
Some things I noted:
That's mostly it. I really liked the way you used the npm commands to implement your functionalities. Clean project as well. Congrats!