From 95febee8422f5374ec721083bdb0f065f5df415f Mon Sep 17 00:00:00 2001 From: Mathis Vehils-Vinals Date: Wed, 17 Dec 2025 09:23:17 +0100 Subject: [PATCH 1/2] Up my solution --- numpy_questions.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/numpy_questions.py b/numpy_questions.py index 07a10c1..0ba5246 100644 --- a/numpy_questions.py +++ b/numpy_questions.py @@ -40,7 +40,9 @@ def max_index(X): i = 0 j = 0 - # TODO + if not isinstance(X, np.ndarray) or X.ndim != 2: + raise ValueError("X must be a 2D numpy array") + i, j = np.unravel_index(np.argmax(X), X.shape) return i, j @@ -62,6 +64,9 @@ def wallis_product(n_terms): pi : float The approximation of order `n_terms` of pi using the Wallis product. """ - # XXX : The n_terms is an int that corresponds to the number of - # terms in the product. For example 10000. - return 0. + if n_terms == 0: + return 2.0 + n = np.arange(1, n_terms + 1) + + res = (4 * n**2) / (4 * n**2 - 1) + return 2 * np.prod(res) From f8e6bd87ac3ac67bca6ff50e49d74be7cc16ab9f Mon Sep 17 00:00:00 2001 From: Mathis Vehils-Vinals Date: Wed, 17 Dec 2025 11:03:25 +0100 Subject: [PATCH 2/2] trigger