feat(skill): add --coder codex reversed-roles support#286
Conversation
Add --role coder to run_external.py so Codex can be invoked for plan writing turns. Document the reversed-roles flow in SKILL.md and update the slash command to accept --coder codex. Add a dry-run test covering the new coder role path. Closes #285 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Review verdict: Blocking Reversed-role dry-run support is added, but the documented skill flow does not configure Claude as the reviewer for resume/approval tracking. Blocking issues
-- OpenAI Codex |
|
Review verdict: Approved The PR successfully implements support for using Codex (or Gemini) as the coder agent, enabling the 'reversed roles' flow (Codex as coder, Claude as reviewer) as described in Issue #285. The orchestrator has been effectively refactored to be agent-agnostic, and the Skill mode helpers now correctly handle these alternative configurations. Test coverage is comprehensive, including new integration tests for the reversed roles flow. Future follow-ups
-- Google Gemini |
Codex's blocking review (PR #286) identified that SKILL.md documented the reversed-roles flow without specifying --reviewers claude in the build-resume call. Without that, build-resume ignores Claude's posted review on any subsequent resume attempt, causing the loop to repeat review turns. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Review verdict: Approved Round 2 review found no blocking issues; the reversed-role resume tracking fix now configures Claude as the reviewer. Prior unresolved item dispositions
-- OpenAI Codex |
|
Review verdict: Approved Verified that item-1 from round 1 has been addressed. SKILL.md and the Claude command instructions now correctly specify Prior unresolved item dispositions
-- Google Gemini |
Summary
--role {reviewer,coder}argument tohelpers/run_external.pyso Codex can be invoked for coder (plan-writing) turns, not just reviewer turns--role coderproduces a validplan_statestub (markdown +<!-- AGENT_PLAN_STATE: approved -->)SKILL.md.claude/commands/coding-review-agent-loop.mdto accept--coder codexand route to the reversed-roles flowtest_dry_run_coder_role_exits_zero_and_writes_plan_state_stub) that validates the dry-run stub passesplan_statevalidationCloses #285
Test plan
pytest tests/test_skill_helpers.py— all 12 tests pass--role coder --dry-runexit 0 andplan_statevalidation of the stub output🤖 Generated with Claude Code