Enable SwiftLint rule: empty_count (#25434)

* Enable SwiftLint rule: empty_count

Prefer checking `isEmpty` over comparing `count` to zero.
Part of the Orchard SwiftLint rollout campaign.

---

Generated with the help of Claude Code, https://code.claude.com

Co-Authored-By: Claude Code Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix false positive on AggregatedDataPoint

`AggregatedDataPoint.count` is an `Int` property, not a collection count.
Revert to `.count != 0` with inline disable.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>

* Fix 4 more empty_count false positives

Non-collection types with a `.count` property but no `.isEmpty`:
- `ReaderInterestsDataSource`
- `AnyTermWithViewContext`
- `NSMutableOrderedSet`
- Tuple `(count: Int, difference: Int, percentage: Int)`

Found via Jetpack CI build — these targets aren't compiled by the WordPress scheme locally.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>

* Fix 3 more empty_count false positives

`NSMutableArray` and `UIViewController`-typed `self` in closures have no `.isEmpty`.
All 3 in `ReaderStreamViewController.swift`.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>

* Fix NSSet empty_count false positive

`NSSet` has no `.isEmpty` — revert to `.count == 0`.

---

Generated with the help of Claude Code, https://claude.ai/code

Co-Authored-By: Claude Code Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Code Opus 4.6 (1M context) <noreply@anthropic.com>

Author: mokagio

.swiftlint.yml

@@ -26,6 +26,9 @@ only_rules:
 
   - duplicate_imports
 
+  # Prefer checking `isEmpty` over comparing `count` to zero.
+  - empty_count
+
   # Arguments can be omitted when matching enums with associated types if they
   # are not used.
   - empty_enum_arguments

Modules/Sources/JetpackStats/Charts/BarChartView.swift

@@ -158,7 +158,7 @@ struct BarChartView: View {
 
     @ChartContentBuilder
     private var significantPointAnnotations: some ChartContent {
-        if tappedDataPoint == nil, let maxPoint = data.significantPoints.currentMax, data.currentData.count > 0 {
+        if tappedDataPoint == nil, let maxPoint = data.significantPoints.currentMax, !data.currentData.isEmpty {
             PointMark(
                 x: .value("Date", maxPoint.date, unit: data.granularity.component, calendar: context.calendar),
                 y: .value("Value", maxPoint.value)

Modules/Sources/JetpackStats/Charts/LineChartView.swift

@@ -165,7 +165,7 @@ struct LineChartView: View {
 
     @ChartContentBuilder
     private var significantPointAnnotations: some ChartContent {
-        if let maxPoint = data.significantPoints.currentMax, data.currentData.count > 0 {
+        if let maxPoint = data.significantPoints.currentMax, !data.currentData.isEmpty {
             PointMark(
                 x: .value("Date", maxPoint.date, unit: data.granularity.component, calendar: context.calendar),
                 y: .value("Value", maxPoint.value)

Modules/Sources/JetpackStats/Charts/SimpleBarChartView.swift

@@ -102,7 +102,7 @@ struct SimpleBarChartView: View {
 
     @ChartContentBuilder
     private var peakAnnotation: some ChartContent {
-        if let maxPoint = data.currentData.max(by: { $0.value < $1.value }), data.currentData.count > 0 {
+        if let maxPoint = data.currentData.max(by: { $0.value < $1.value }), !data.currentData.isEmpty {
             PointMark(
                 x: .value("Date", maxPoint.date, unit: data.granularity.component),
                 y: .value("Value", maxPoint.value)

Modules/Sources/JetpackStats/Screens/TopListScreenView.swift

@@ -181,7 +181,7 @@ struct TopListScreenView: View {
 
     @ViewBuilder
     private func listContent(data: TopListData) -> some View {
-        if data.items.count > 0 {
+        if !data.items.isEmpty {
             listSection(.top10, data: data)
         }
         if data.items.count > 10 {

Modules/Sources/JetpackStats/Services/Mocks/StatsDataAggregator.swift

@@ -61,7 +61,8 @@ struct StatsDataAggregator {
             case .sum:
                 normalizedData[date] = dataPoint.sum
             case .average:
-                if dataPoint.count > 0 {
+                // swiftlint:disable:next empty_count
+                if dataPoint.count != 0 {
                     normalizedData[date] = dataPoint.sum / dataPoint.count
                 }
             }

Modules/Sources/JetpackStats/Views/TopList/Rows/TopListExternalLinkRowView.swift

@@ -10,7 +10,7 @@ struct TopListExternalLinkRowView: View {
                 .foregroundColor(.primary)
                 .lineLimit(1)
 
-            if item.children.count > 0 {
+            if !item.children.isEmpty {
                 Text(Strings.ArchiveSections.itemCount(item.children.count))
                     .font(.caption)
                     .foregroundColor(.secondary)

Modules/Sources/UITestsFoundation/Screens/CommentsScreen.swift

@@ -68,7 +68,7 @@ public class CommentsScreen: ScreenObject {
     public func verifyCommentsListEmpty() -> CommentsScreen {
         XCTAssertTrue(emptyImage.waitForExistence(timeout: 3))
         XCTAssertTrue(app.staticTexts["Be the first to leave a comment."].isHittable)
-        XCTAssertTrue(app.cells.containing(.button, identifier: "reply-comment-button").count == 0)
+        XCTAssertTrue(app.cells.containing(.button, identifier: "reply-comment-button").isEmpty)
         return self
     }
 

Modules/Sources/WordPressIntelligence/Utilities/ContentExtractor.swift

@@ -26,7 +26,7 @@ public enum ContentExtractor {
     public static func extractRelevantText(from content: String) throws -> String {
         let doc = try SwiftSoup.parse(content)
 
-        guard let body = doc.body(), body.children().count > 0 else {
+        guard let body = doc.body(), !body.children().isEmpty else {
             return content // Return as is
         }
 

Modules/Sources/WordPressKit/JetpackScanThreat.swift

@@ -237,7 +237,7 @@ public struct JetpackThreatContext {
             }
         }
 
-        return (highlights.count > 0) ? highlights : nil
+        return (!highlights.isEmpty) ? highlights : nil
     }
 
     /// Generates an NSRange from an array