Skip to content

Commit dc67739

Browse files
Merge pull request #20 from wordpress-mobile/issue/add_draw_operation
Add Draw Operation
2 parents 324261b + abc8347 commit dc67739

4 files changed

Lines changed: 17 additions & 6 deletions

File tree

MediaEditor.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'MediaEditor'
3-
s.version = '1.1.0-beta.1'
3+
s.version = '1.1.0-beta.2'
44
s.summary = 'An extensible Media Editor for iOS.'
55

66
s.description = <<-DESC

Sources/Capabilities/Drawing/MediaEditorDrawing.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,13 @@ class MediaEditorDrawing: UIViewController {
5555
}
5656

5757
@IBAction func done(_ sender: Any) {
58-
guard let image = annotationView.image else {
58+
guard annotationView.canUndo,
59+
let image = annotationView.image else {
5960
onCancel?()
6061
return
6162
}
6263

63-
onFinishEditing?(image, [.other])
64+
onFinishEditing?(image, [.draw])
6465
}
6566
}
6667

Sources/Enums/MediaEditorOperation.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ public enum MediaEditorOperation {
55
case rotate
66
case filter
77
case other
8+
case draw
89
}

Tests/Capabilities/Drawing/MediaEditorDrawingTests.swift

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,10 @@ class MediaEditorDrawingTests: XCTestCase {
6060
let mediaEditorDrawing = MediaEditorDrawing.initialize(image, onFinishEditing: { finishedImage, _ in
6161
result = finishedImage
6262
}, onCancel: {}) as! MediaEditorDrawing
63+
let annotationViewMock = MediaEditorAnnotationViewMock()
6364

6465
mediaEditorDrawing.loadView()
66+
mediaEditorDrawing.annotationView = annotationViewMock
6567
mediaEditorDrawing.viewDidLoad()
6668
mediaEditorDrawing.done(self)
6769

@@ -70,17 +72,17 @@ class MediaEditorDrawingTests: XCTestCase {
7072

7173
func testModifiedImageIsReturnedIfChangesAreMade() {
7274
let image = UIImage(systemName: "arrowshape.turn.up.left")!
73-
let drawingUrl = Bundle(for: MediaEditorDrawingTests.self).url(forResource: "demo-drawing", withExtension: nil)!
74-
let drawingData = try! Data(contentsOf: drawingUrl)
7575

7676
var result: UIImage? = nil
7777
let mediaEditorDrawing = MediaEditorDrawing.initialize(image, onFinishEditing: { finishedImage, _ in
7878
result = finishedImage
7979
}, onCancel: {}) as! MediaEditorDrawing
80+
let annotationViewMock = MediaEditorAnnotationViewMock()
81+
annotationViewMock.image = UIImage()
8082

8183
mediaEditorDrawing.loadView()
8284
mediaEditorDrawing.viewDidLoad()
83-
mediaEditorDrawing.annotationView.drawingData = drawingData
85+
mediaEditorDrawing.annotationView = annotationViewMock
8486
mediaEditorDrawing.view.setNeedsLayout()
8587
mediaEditorDrawing.view.layoutIfNeeded()
8688

@@ -98,3 +100,10 @@ class MediaEditorDrawingTests: XCTestCase {
98100
expect(mediaEditorDrawing.redoButton.isEnabled).to(beFalse())
99101
}
100102
}
103+
104+
@available(iOS 13.0, *)
105+
private class MediaEditorAnnotationViewMock: MediaEditorAnnotationView {
106+
override var canUndo: Bool {
107+
return true
108+
}
109+
}

0 commit comments

Comments
 (0)