Skip to content

Django 5.2 Compatibility: BaseFinder find #11

@dbIgel

Description

@dbIgel

Django 5.2 changed the BaseFinder method findwhich now should use find_all instead of all, see django/django@0fdcf10 , django/django@8719a61 and https://github.com/django/django/blob/main/django/contrib/staticfiles/finders.py#L65

This currently breaks requests for assets as https://github.com/django/django/blob/802baf5da5b8d8b44990a8214a43b951e7ab8b39/django/contrib/staticfiles/finders.py#L354 calls the find method with a set find_all attribute.

TypeError: NodeModulesFinder.find() got an unexpected keyword argument find_all

Recommended Fix

Change the method to accept find_all until only django 5.2+/6.1 is supported.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions