Skip to content

Commit c9aa3ef

Browse files
authored
Used plain go vet instead of golangci-lint (#54)
Co-authored-by: Tomas Vesely <448809+wham@users.noreply.github.com>
1 parent ac4a2eb commit c9aa3ef

3 files changed

Lines changed: 12 additions & 32 deletions

File tree

.github/workflows/build.yml

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ jobs:
2424
- name: Install dependencies
2525
run: go mod download
2626

27+
- name: Vet
28+
run: go vet ./...
29+
2730
- name: Build
2831
run: |
2932
CGO_ENABLED=1 CGO_CFLAGS="-DSQLITE_ENABLE_FTS5" CGO_LDFLAGS="-lm" \
@@ -36,22 +39,3 @@ jobs:
3639
- name: Run tests
3740
if: false # Enable when tests exist
3841
run: go test -v ./...
39-
40-
lint:
41-
name: Lint
42-
runs-on: ubuntu-latest
43-
44-
steps:
45-
- name: Checkout code
46-
uses: actions/checkout@v4
47-
48-
- name: Set up Go
49-
uses: actions/setup-go@v5
50-
with:
51-
go-version: "1.24"
52-
53-
- name: golangci-lint
54-
uses: golangci/golangci-lint-action@v6
55-
with:
56-
version: latest
57-
args: --timeout=5m

main.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1315,23 +1315,23 @@ curl -L https://github.com/wham/github-brain/releases/download/v1.2.3/github-bra
13151315

13161316
### Linting
13171317

1318-
Use **golangci-lint** with default configuration for code quality checks.
1318+
Use **go vet** for code quality checks.
13191319

1320-
**Running the linter:**
1320+
**Running go vet:**
13211321

13221322
```bash
13231323
# Standalone
1324-
golangci-lint run --timeout=5m
1324+
go vet ./...
13251325

13261326
# Integrated with build (via scripts/run)
13271327
./scripts/run [command]
13281328
```
13291329

13301330
**CI Integration:**
13311331

1332-
- Linting runs automatically on all PRs via `.github/workflows/build.yml`
1333-
- Build fails if linter finds issues (blocking)
1334-
- In local development (`scripts/run`), linting runs but is non-blocking to allow rapid iteration
1332+
- `go vet` runs automatically on all PRs via `.github/workflows/build.yml`
1333+
- Build fails if `go vet` finds issues (blocking)
1334+
- In local development (`scripts/run`), `go vet` runs but is non-blocking to allow rapid iteration
13351335

13361336
### Release Model
13371337

scripts/run

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,9 @@
22
set -e
33
cd "$(dirname "$0")/.."
44

5-
# Lint the code (non-blocking in development)
6-
echo "Running linter..."
7-
if command -v golangci-lint &> /dev/null; then
8-
golangci-lint run --timeout=5m || echo "Warning: Linter found issues (non-blocking in development)"
9-
else
10-
echo "Warning: golangci-lint not found, skipping linting"
11-
fi
5+
# Run go vet (non-blocking in development)
6+
echo "Running go vet..."
7+
go vet ./... || echo "Warning: go vet found issues (non-blocking in development)"
128

139
# Build with FTS5 support enabled
1410
CGO_ENABLED=1 CGO_CFLAGS="-DSQLITE_ENABLE_FTS5" CGO_LDFLAGS="-lm" go build -gcflags="all=-N -l" -o ./build/github-brain .

0 commit comments

Comments
 (0)