feat: remove deprecated bypass option from proxy configuration

Author: bjohansebas

lib/Server.js

@@ -3,7 +3,6 @@
 const os = require("node:os");
 const path = require("node:path");
 const url = require("node:url");
-const util = require("node:util");
 const fs = require("graceful-fs");
 const ipaddr = require("ipaddr.js");
 const { validate } = require("schema-utils");
@@ -138,14 +137,7 @@ const schema = require("./options.json");
  */
 
 /**
- * @callback ByPass
- * @param {Request} req
- * @param {Response} res
- * @param {ProxyConfigArrayItem} proxyConfig
- */
-
-/**
- * @typedef {{ path?: HttpProxyMiddlewareOptionsFilter | undefined, context?: HttpProxyMiddlewareOptionsFilter | undefined } & { bypass?: ByPass } & HttpProxyMiddlewareOptions } ProxyConfigArrayItem
+ * @typedef {{ path?: HttpProxyMiddlewareOptionsFilter | undefined, context?: HttpProxyMiddlewareOptionsFilter | undefined } & HttpProxyMiddlewareOptions } ProxyConfigArrayItem
  */
 
 /**
@@ -2148,10 +2140,9 @@ class Server {
        * @returns {RequestHandler | undefined} request handler
        */
       const getProxyMiddleware = (proxyConfig) => {
-        // It is possible to use the `bypass` method without a `target` or `router`.
-        // However, the proxy middleware has no use in this case, and will fail to instantiate.
         if (proxyConfig.target) {
-          const context = proxyConfig.context || proxyConfig.path;
+          const context =
+            proxyConfig.context || proxyConfig.path || proxyConfig.pathFilter;
 
           return createProxyMiddleware({
             ...proxyConfig,
@@ -2162,15 +2153,6 @@ class Server {
         if (proxyConfig.router) {
           return createProxyMiddleware(proxyConfig);
         }
-
-        // TODO improve me after drop `bypass` to always generate error when configuration is bad
-        if (!proxyConfig.bypass) {
-          util.deprecate(
-            () => {},
-            `Invalid proxy configuration:\n\n${JSON.stringify(proxyConfig, null, 2)}\n\nThe use of proxy object notation as proxy routes has been removed.\nPlease use the 'router' or 'context' options. Read more at https://github.com/chimurai/http-proxy-middleware/tree/v2.0.6#http-proxy-middleware-options`,
-            "DEP_WEBPACK_DEV_SERVER_PROXY_ROUTES_ARGUMENT",
-          )();
-        }
       };
 
       /**
@@ -2236,40 +2218,11 @@ class Server {
             }
           }
 
-          // - Check if we have a bypass function defined
-          // - In case the bypass function is defined we'll retrieve the
-          // bypassUrl from it otherwise bypassUrl would be null
-          // TODO remove in the next major in favor `context` and `router` options
-          const isByPassFuncDefined = typeof proxyConfig.bypass === "function";
-          if (isByPassFuncDefined) {
-            util.deprecate(
-              () => {},
-              "Using the 'bypass' option is deprecated. Please use the 'router' or 'context' options. Read more at https://github.com/chimurai/http-proxy-middleware/tree/v2.0.6#http-proxy-middleware-options",
-              "DEP_WEBPACK_DEV_SERVER_PROXY_BYPASS_ARGUMENT",
-            )();
-          }
-          const bypassUrl = isByPassFuncDefined
-            ? await /** @type {ByPass} */ (proxyConfig.bypass)(
-                req,
-                res,
-                proxyConfig,
-              )
-            : null;
-
-          if (typeof bypassUrl === "boolean") {
-            // skip the proxy
-            res.statusCode = 404;
-            req.url = "";
-            next();
-          } else if (typeof bypassUrl === "string") {
-            // byPass to that url
-            req.url = bypassUrl;
-            next();
-          } else if (proxyMiddleware) {
+          if (proxyMiddleware) {
             return proxyMiddleware(req, res, next);
-          } else {
-            next();
           }
+
+          next();
         };
 
         middlewares.push({