Skip to content

Commit 6c6bcbe

Browse files
committed
fix(changelog): simplify comparison UI and remove unused code in app.js
1 parent c4d5b3c commit 6c6bcbe

3 files changed

Lines changed: 0 additions & 74 deletions

File tree

docs/changelog/assets/js/app.js

Lines changed: 0 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -677,20 +677,10 @@ window.onhashchange = () => {
677677

678678
populateVersions();
679679

680-
let comparisonMode = false;
681680
/* ============================================
682681
UI HELPER FUNCTIONS
683682
============================================ */
684683

685-
/**
686-
* Show loading state for comparison
687-
*/
688-
const showComparisonLoading = () => {
689-
if (!comparisonResults) return;
690-
comparisonResults.innerHTML = '<p style="text-align: center; padding: 20px;">Loading comparison...</p>';
691-
comparisonResults.classList.remove('hide');
692-
};
693-
694684
/**
695685
* Show error state for comparison
696686
* @param {Error} error - The error object
@@ -718,9 +708,6 @@ const showComparisonError = (error) => {
718708
* @param {string} versionB - Target version (optional)
719709
*/
720710
const switchToComparisonMode = (versionA = null, versionB = null) => {
721-
// Update mode
722-
comparisonMode = true;
723-
724711
// Update button states
725712
if (comparisonViewBtn && singleViewBtn) {
726713
comparisonViewBtn.classList.add('active', 'btn-primary');
@@ -972,18 +959,6 @@ const handleEnhancedComparisonURL = async () => {
972959

973960
return {shouldCompare: false};
974961
};
975-
976-
/**
977-
* Populate version dropdowns for comparison mode
978-
*/
979-
const populateComparisonVersions = () => {
980-
if (versionSelectDropdown && versionSelectDropdown.innerHTML) {
981-
const options = versionSelectDropdown.innerHTML;
982-
if (versionASelect) versionASelect.innerHTML = options;
983-
if (versionBSelect) versionBSelect.innerHTML = options;
984-
}
985-
};
986-
987962
/**
988963
* Reset comparison form selections
989964
*/
@@ -1067,7 +1042,6 @@ const updatePrereleaseLabels = () => {
10671042
* Handle stable version changes - fetch changelogs and populate packages
10681043
*/
10691044
const handleStableVersionChange = async () => {
1070-
console.log('🟢 handleStableVersionChange FIRED');
10711045
const stableA = versionASelect.value;
10721046
const stableB = versionBSelect.value;
10731047

@@ -1095,7 +1069,6 @@ const handleStableVersionChange = async () => {
10951069
* Handle package selection - populate pre-release versions
10961070
*/
10971071
const handlePackageChange = () => {
1098-
console.log('🟢 handlePackageChange FIRED');
10991072
const selectedPackage = comparisonPackageSelect.value;
11001073

11011074
if (versionAPrereleaseSelect) versionAPrereleaseSelect.value = '';
@@ -1130,8 +1103,6 @@ const handlePackageChange = () => {
11301103
* Switch to single view mode
11311104
*/
11321105
const switchToSingleViewMode = () => {
1133-
console.log('🔵 Switching to SINGLE VIEW mode');
1134-
comparisonMode = false;
11351106

11361107
// Update button styles
11371108
singleViewBtn.classList.add('active', 'btn-primary');
@@ -1145,25 +1116,6 @@ const switchToSingleViewMode = () => {
11451116
clearComparisonURLParams();
11461117
};
11471118

1148-
/**
1149-
* Switch to comparison view mode
1150-
*/
1151-
const switchToComparisonViewMode = () => {
1152-
console.log('🔵 Switching to COMPARISON VIEW mode');
1153-
comparisonMode = true;
1154-
1155-
// Update button styles
1156-
comparisonViewBtn.classList.add('active', 'btn-primary');
1157-
comparisonViewBtn.classList.remove('btn-default');
1158-
singleViewBtn.classList.remove('active', 'btn-primary');
1159-
singleViewBtn.classList.add('btn-default');
1160-
1161-
// Toggle visibility (centralized view state)
1162-
updateUIVisibility('comparison');
1163-
1164-
populateComparisonVersions();
1165-
};
1166-
11671119
/**
11681120
* Validate comparison form inputs
11691121
*/
@@ -1357,10 +1309,8 @@ const handleClearClick = () => {
13571309
*/
13581310
const setupComparisonEventListeners = () => {
13591311
if (comparisonListenersInitialized) {
1360-
console.log('🔴 Comparison listeners already initialized,skipping......');
13611312
return;
13621313
}
1363-
console.log('🟢 Setting up comparison event listeners first time......');
13641314
comparisonListenersInitialized = true;
13651315
// Mode toggle buttons
13661316
if (singleViewBtn) singleViewBtn.addEventListener('click', switchToSingleViewMode);
@@ -1451,12 +1401,6 @@ const initializeComparisonMode = async () => {
14511401
await loadEnhancedComparisonFromURL(enhancedParams);
14521402
return;
14531403
}
1454-
1455-
// Check for standard comparison URL
1456-
const urlParams = await handleComparisonURLParams();
1457-
if (urlParams.shouldCompare) {
1458-
await loadStandardComparisonFromURL(urlParams);
1459-
}
14601404
};
14611405

14621406
/**

docs/changelog/assets/js/comparison-view.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,6 @@ const collectCommitsFromStable = (packageData, stableVersion, versionA, versionB
294294
const generatePackageComparisonData = (packageName, versionASpecific, versionBSpecific, changelogA, changelogB) => {
295295
const effectiveVersionA = getEffectiveVersion(changelogA, packageName, versionASpecific);
296296
const effectiveVersionB = getEffectiveVersion(changelogB, packageName, versionBSpecific);
297-
console.log('effectiveVersionA', effectiveVersionA);
298-
console.log('effectiveVersionB', effectiveVersionB);
299297
// Get package data from changelogs
300298
const pkgDataA = changelogA[packageName]?.[effectiveVersionA];
301299
const pkgDataB = changelogB[packageName]?.[effectiveVersionB];
@@ -334,18 +332,7 @@ const generatePackageComparisonData = (packageName, versionASpecific, versionBSp
334332
//Export All the functions
335333
export {
336334
comparisonState,
337-
findLatestPackageVersion,
338-
getEffectiveVersion,
339-
getPackageVersion,
340-
determinePackageStatus,
341-
createPackageComparisonRow,
342-
calculateComparisonStats,
343-
buildPackagesList,
344335
generatePackageComparisonData,
345336
sortStableVersions,
346-
isPreRelease,
347-
isExactStable,
348-
getPreReleaseNum,
349-
getPreReleaseTag,
350337
collectCommitsFromStable,
351338
};

docs/changelog/index.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,6 @@
158158
<label for="comparison-package-select">Package for comparison:</label>
159159
<select id="comparison-package-select" class="full-width">
160160
<option value="">Select a package for comparison</option>
161-
=======
162-
<label for="comparison-package-select">Package (optional for full comparison):</label>
163-
<select id="comparison-package-select" class="full-width">
164-
<option value="">Select a package (optional)</option>
165-
>>>>>>> de805712c1baa97a2d9aa67f0481d24cad266728
166161
</select>
167162
</div>
168163
</div>

0 commit comments

Comments
 (0)