Conversation
87ccf4fd Merge pull request #155 from weaveworks/go-1-12 c31bc286 Update lint script to work with Go 1.12 ed8e380d Update to Go 1.12.1 git-subtree-dir: tools git-subtree-split: 87ccf4fd1e5679cd2d664f8c8a798d7943aa1171
Flags for static build copied from Cortex. Disable CGO so static linking works as desired Use Go 1.12.1 to run integration tests
Errors flagged by newer go vet
Newer `go vet` complains about this
Just cosmetic changes
awh
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want this so we can merge #2321, but it seems like a good idea to update anyway.
Note the newer tools threw up some actual bugs in the code (generally you wouldn't see them unless a particular error happened)
The update to
tools/linthas been done in its repo then revendored here. weaveworks/build-tools#155