Explain or update the TWAE properties in csproj

[ttd2089]

wimm.Secundatives/wimm.Secundatives.csproj contains the following property groups:

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <NoWarn>1591</NoWarn>
    <WarningsAsErrors />
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
  </PropertyGroup>

It's not clear (to me) why we need an empty <WarningsAsErrors> element in the release configuration but not in the debug configuration, nor why we are suppressing warnings about undocumented public interface in release but not in debug. It seems like we should be fine with just <TreatWarningsAsErrors> in the unconditional property group. Maybe this is an idiosyncrasy of (an older version of) Visual Studio?

[Insomniak47]

When we first set this up we both found it annoying that we couldn't compile in debug and build before writing in comments which is why we made it conditional - it was a workflow thing

[ttd2089]

That sounds reasonable but I wouldn't read this configuration as accomplishing that. This says we're ignoring 1591 in release doesn't it?

[Insomniak47]

You're right. In that case I've got no clue lol