Skip to content

Commit 43f5235

Browse files
fix: Resolve merge issues
1 parent c12e36f commit 43f5235

16 files changed

Lines changed: 23 additions & 378 deletions

File tree

docs/design/wandb_v2/struct_usage_mapping.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ This document maps struct definitions and their usage (reads/writes) across the
4747

4848
### MySQL Structs
4949

50-
#### WBMySQLSpec
50+
#### MySQLSpec
5151
- 📝 **Defined**: `api/v2/weightsandbiases_types.go:84`
5252
- 📖 **Read by**:
5353
- `internal/controller/translator/v2/mysql.go` - BuildMySQLSpec(), BuildMySQLDefaults()
5454
- ✍️ **Written by**:
55-
- `internal/controller/translator/v2/mysql.go` - Creates WBMySQLSpec{} literals with defaults
55+
- `internal/controller/translator/v2/mysql.go` - Creates MySQLSpec{} literals with defaults
5656

5757
#### WBMySQLConfig
5858
- 📝 **Defined**: `api/v2/weightsandbiases_types.go:95`
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
package tenant
22

3-
// Preserve (for when WBRetentionPolicy's OnDelete == WBPreserveOnDelete) is
3+
// Preserve (for when RetentionPolicy's OnDelete == PreserveOnDelete) is
44
// works out of the box with no extra WandB intervention required.

internal/controller/translator/v2/clickhouse.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ func ToClickHouseVendorSpec(
7070
}
7171

7272
reclaimPolicy := v1.PVCReclaimPolicyUnspecified
73-
if wandb.GetRetentionPolicy(wandb.Spec.ClickHouse.WBInfraSpec).OnDelete == apiv2.WBPurgeOnDelete {
73+
if wandb.GetRetentionPolicy(wandb.Spec.ClickHouse.InfraSpec).OnDelete == apiv2.PurgeOnDelete {
7474
reclaimPolicy = v1.PVCReclaimPolicyDelete
7575
}
7676

@@ -178,6 +178,6 @@ func BuildWandbClickhouseLabels(wandb *apiv2.WeightsAndBiases) map[string]string
178178
return BuildWandbLabels(wandb, translator.ClickhouseModuleName)
179179
}
180180

181-
func ToClickHouseOnDeleteRule(wandb *apiv2.WeightsAndBiases, retentionPolicy apiv2.WBRetentionPolicy) translator.OnDeleteRule {
181+
func ToClickHouseOnDeleteRule(wandb *apiv2.WeightsAndBiases, retentionPolicy apiv2.RetentionPolicy) translator.OnDeleteRule {
182182
return ToOnDeleteRule(wandb, retentionPolicy, translator.ClickhouseModuleName)
183183
}

internal/controller/translator/v2/kafka.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,6 @@ func BuildWandbKafkaLabels(wandb *apiv2.WeightsAndBiases) map[string]string {
217217
return BuildWandbLabels(wandb, translator.KafkaModuleName)
218218
}
219219

220-
func ToKafkaOnDeleteRule(wandb *apiv2.WeightsAndBiases, retentionPolicy apiv2.WBRetentionPolicy) translator.OnDeleteRule {
220+
func ToKafkaOnDeleteRule(wandb *apiv2.WeightsAndBiases, retentionPolicy apiv2.RetentionPolicy) translator.OnDeleteRule {
221221
return ToOnDeleteRule(wandb, retentionPolicy, translator.KafkaModuleName)
222222
}

internal/controller/translator/v2/maria.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ exec /bin/mysqld_exporter --config.my-cnf=/tmp/.my.cnf
6060

6161
func ToMariaDBMySQLVendorSpec(
6262
ctx context.Context,
63-
spec apiv2.WBMySQLSpec,
63+
spec apiv2.MySQLSpec,
6464
owner metav1.Object,
6565
scheme *runtime.Scheme,
6666
) (*v1alpha1.MariaDB, error) {

internal/controller/translator/v2/minio.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,6 @@ func BuildWandbMinioLabels(wandb *apiv2.WeightsAndBiases) map[string]string {
147147
return BuildWandbLabels(wandb, translator.MinioModuleName)
148148
}
149149

150-
func ToMinioOnDeleteRule(wandb *apiv2.WeightsAndBiases, retentionPolicy apiv2.WBRetentionPolicy) translator.OnDeleteRule {
150+
func ToMinioOnDeleteRule(wandb *apiv2.WeightsAndBiases, retentionPolicy apiv2.RetentionPolicy) translator.OnDeleteRule {
151151
return ToOnDeleteRule(wandb, retentionPolicy, translator.MinioModuleName)
152152
}

0 commit comments

Comments
 (0)