Skip to content

Commit 013e49e

Browse files
committed
allow sign app optionally
1 parent 1d00d88 commit 013e49e

File tree

2 files changed

+8
-54
lines changed

2 files changed

+8
-54
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,29 +4,11 @@ on:
44
pull_request:
55
branches:
66
- main
7-
paths:
8-
- "**.go"
9-
- "go.mod"
10-
- "go.sum"
11-
- "**.js"
12-
- "**.jsx"
13-
- "**.ts"
14-
- "**.tsx"
15-
- "package.json"
16-
- "bun.lockb"
177
push:
188
branches:
199
- main
20-
paths:
21-
- "**.go"
22-
- "go.mod"
23-
- "go.sum"
24-
- "**.js"
25-
- "**.jsx"
26-
- "**.ts"
27-
- "**.tsx"
28-
- "package.json"
29-
- "bun.lockb"
10+
# Allow manual trigger
11+
workflow_dispatch:
3012

3113
jobs:
3214
go-tests:

.github/workflows/release.yml

Lines changed: 6 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
name: Release
22

33
on:
4-
# Only run on version tags (releases)
54
push:
65
tags:
76
- "v*"
8-
# TEMPORARY: Run on PR for testing build fixes
9-
pull_request:
107
branches:
118
- main
12-
# Allow manual trigger
139
workflow_dispatch:
1410

1511
env:
@@ -104,30 +100,6 @@ jobs:
104100
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
105101
MACOS_CERTIFICATE_PASSWORD: ${{ secrets.MACOS_CERTIFICATE_PASSWORD }}
106102

107-
- name: Debug Build Output
108-
run: |
109-
echo "=== Current directory ==="
110-
pwd
111-
echo ""
112-
echo "=== All files in current directory ==="
113-
ls -la
114-
echo ""
115-
echo "=== Contents of bin/ directory ==="
116-
ls -la bin/ 2>/dev/null || echo "bin/ directory not found"
117-
echo ""
118-
echo "=== Contents of build/bin/ directory ==="
119-
ls -la build/bin/ 2>/dev/null || echo "build/bin/ directory not found"
120-
echo ""
121-
echo "=== Find all executables ==="
122-
find . -type f \( -name "*.exe" -o -name "devtoolbox*" -o -perm /111 \) 2>/dev/null | head -20
123-
echo ""
124-
echo "=== Find all .app bundles ==="
125-
find . -type d -name "*.app" 2>/dev/null | head -10
126-
echo ""
127-
echo "=== Find all bin directories ==="
128-
find . -type d -name "bin" 2>/dev/null
129-
shell: bash
130-
131103
# Import macOS certificates for signing (optional - only if secrets are configured)
132104
- name: Import macOS Certificates
133105
if: matrix.os == 'macos-latest' && github.event_name != 'pull_request' && env.HAS_CERTS == 'true'
@@ -148,14 +120,14 @@ jobs:
148120
if [ -d "bin/$BINARY_NAME.app" ]; then
149121
# Create a zip for notarization
150122
ditto -c -k --keepParent "bin/$BINARY_NAME.app" "bin/devtoolbox.zip"
151-
123+
152124
# Submit for notarization
153125
xcrun notarytool submit "bin/devtoolbox.zip" \
154126
--apple-id "${{ secrets.APPLE_ID }}" \
155127
--password "${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}" \
156128
--team-id "${{ secrets.APPLE_TEAM_ID }}" \
157129
--wait
158-
130+
159131
# Staple the notarization ticket
160132
xcrun stapler staple "bin/$BINARY_NAME.app"
161133
else
@@ -171,17 +143,17 @@ jobs:
171143
- name: Package Artifacts
172144
run: |
173145
mkdir -p release
174-
146+
175147
# Discover the actual binary name (DevToolbox, devtoolbox, etc.)
176148
BINARY_NAME=$(ls bin/ | grep -i "devtoolbox" | head -1)
177149
echo "Found binary: $BINARY_NAME"
178-
150+
179151
if [ -z "$BINARY_NAME" ]; then
180152
echo "ERROR: Could not find devtoolbox binary in bin/"
181153
ls -la bin/
182154
exit 1
183155
fi
184-
156+
185157
# Check if it's an .app bundle (macOS) or just a binary
186158
if [ -d "bin/$BINARY_NAME.app" ]; then
187159
# macOS with .app bundle
@@ -202,7 +174,7 @@ jobs:
202174
# Linux or macOS binary (no .app): create tar.gz
203175
tar -czf "release/DevToolbox.tar.gz" -C bin "$BINARY_NAME"
204176
fi
205-
177+
206178
echo "=== Release contents ==="
207179
ls -la release/
208180
shell: bash

0 commit comments

Comments
 (0)