Memory Leak in vsg::ref_ptr<vsg::Data> when using convertToVsg with osg::Image

[xiaoxin0214]

In the function vsg::ref_ptrvsg::Data convertToVsg(const osg::Image* image, bool mapRGBtoRGBAHint), if we simply return nullptr without performing any additional operations, no memory leak occurs:

vsg::ref_ptr<vsg::Data> convertToVsg(const osg::Image* image, bool mapRGBtoRGBAHint)
{
    return nullptr;
}

However, if we execute the conversion logic but still end up returning nullptr, a memory leak occurs.

[xiaoxin0214]

Perhaps we should set layout.allocatorType to ALLOCATOR_TYPE_NEW_DELETE instead of the default ALLOCATOR_TYPE_VSG_ALLOCATOR, since the memory is allocated by OSG.

layout.allocatorType = vsg::ALLOCATOR_TYPE_NEW_DELETE;

[robertosfield]

On Fri, 13 Jun 2025 at 03:36, xiaoxin0214 ***@***.***> wrote: *xiaoxin0214* created an issue (vsg-dev/osg2vsg#84) <#84> in vsg::ref_ptr<vsg::Data> convertToVsg(const osg::Image* image, bool mapRGBtoRGBAHint)function,we create an osg::Image object and transfer its data ownership to a vsg::Array2D instance: // we want to pass ownership of the new_image data on to the vsg_image so reset the allocation mode on the image to prevent deletion. new_image->setAllocationMode(osg::Image::NO_DELETE); vsg_data = vsg::Array2D<T>::create(image->s(), image->t(), reinterpret_cast<T*>(image->data()), vsg::Data::Properties{format}); However, when vsg::Array2D is destroyed, the internal _delete() function fails to properly free because the _storage is null void _delete() { if (!_storage && _data) { if (properties.allocatorType == ALLOCATOR_TYPE_NEW_DELETE) delete[] _data; else if (properties.allocatorType == ALLOCATOR_TYPE_MALLOC_FREE) std::free(_data); else if (properties.allocatorType != 0) vsg::deallocate(_data); } }

Could it be that you are mis-reading the above Array2D code? The local delete shoould only be run when _storage is null, and there is `if (!storage & ..` used to insure this. Message ID: ***@***.***>

…

[robertosfield]

On Fri, 13 Jun 2025 at 07:34, xiaoxin0214 ***@***.***> wrote: *xiaoxin0214* left a comment (vsg-dev/osg2vsg#84) <#84 (comment)> Perhaps we should set layout.allocatorType to ALLOCATOR_TYPE_NEW_DELETE instead of the default ALLOCATOR_TYPE_VSG_ALLOCATOR, since the memory is allocated by OSG. layout.allocatorType = vsg::ALLOCATOR_TYPE_NEW_DELETE;Message ID: ***@***.***>

That sounds more plausible. osg2vsg was written prior to the vsg::Allocator, explicitly telling it to do the same as the OSG makes sense.