Skip to content

updated requirements with specific versioning#2

Open
totallynotmanas wants to merge 1 commit into
volpe-framework:mainfrom
totallynotmanas:requirements
Open

updated requirements with specific versioning#2
totallynotmanas wants to merge 1 commit into
volpe-framework:mainfrom
totallynotmanas:requirements

Conversation

@totallynotmanas
Copy link
Copy Markdown

This PR optimizes the build configuration and Docker setup to enhance reliability, performance, and long-term maintainability. Key focus areas include image size reduction, cross-engine support (Docker/Podman), and build reproducibility.

Changes

Dockerfile

  • Optimization: Added ENV PIP_NO_CACHE_DIR=1 to minimize image footprint.

  • Stability: Improved package installation by upgrading pip, setuptools, and wheel.

  • Security: Added ca-certificates for robust SSL/TLS support.

  • Caching: Optimized layer caching by moving the requirements.txt copy step before volpe_py.

  • Readability: Cleaned up command formatting and simplified the CMD entry point.

build_image.sh

  • Robustness: Added proper bash shebang and strict error handling (set -euo pipefail).

  • Compatibility: Implemented automatic Docker/Podman detection with validation logic to error out if no container engine is found.

  • Safety: Improved variable quoting for paths with spaces and switched to rm -f for fail-safe cleanups.

requirements.txt

  • Reproducibility: Added version constraints for grpcio-tools>=1.78.1 and protobuf>=6.31.0 to prevent breaking changes in future builds.

Copy link
Copy Markdown
Collaborator

@aadit-n3rdy aadit-n3rdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks good overall, but it just struck me that we should probably fix the protobuf version across the entire project, would be great if you could use "==" for protobuf, and set the same version across all the repos where it's used. Will discuss this on WA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants