updated requirements with specific versioning#2
Open
totallynotmanas wants to merge 1 commit into
Open
Conversation
aadit-n3rdy
requested changes
May 2, 2026
Collaborator
aadit-n3rdy
left a comment
There was a problem hiding this comment.
Hey, looks good overall, but it just struck me that we should probably fix the protobuf version across the entire project, would be great if you could use "==" for protobuf, and set the same version across all the repos where it's used. Will discuss this on WA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the build configuration and Docker setup to enhance reliability, performance, and long-term maintainability. Key focus areas include image size reduction, cross-engine support (Docker/Podman), and build reproducibility.
Changes
Dockerfile
Optimization: Added ENV PIP_NO_CACHE_DIR=1 to minimize image footprint.
Stability: Improved package installation by upgrading pip, setuptools, and wheel.
Security: Added ca-certificates for robust SSL/TLS support.
Caching: Optimized layer caching by moving the requirements.txt copy step before volpe_py.
Readability: Cleaned up command formatting and simplified the CMD entry point.
build_image.sh
Robustness: Added proper bash shebang and strict error handling (set -euo pipefail).
Compatibility: Implemented automatic Docker/Podman detection with validation logic to error out if no container engine is found.
Safety: Improved variable quoting for paths with spaces and switched to rm -f for fail-safe cleanups.
requirements.txt