From 447d19d70109ebbf3758b66f88d2d647eb9026ff Mon Sep 17 00:00:00 2001 From: MK Date: Mon, 13 Apr 2026 09:42:51 +0800 Subject: [PATCH 1/2] fix: remove unnecessary quotes from vitest-dev override in upgrade script The upgrade script was wrapping the vitest-dev override value in single quotes, but pnpm-workspace.yaml stores it unquoted. This caused a spurious formatting change on every upgrade run. Closes #1367 --- .github/scripts/upgrade-deps.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/upgrade-deps.mjs b/.github/scripts/upgrade-deps.mjs index fac13b86df..02491a4960 100644 --- a/.github/scripts/upgrade-deps.mjs +++ b/.github/scripts/upgrade-deps.mjs @@ -64,7 +64,7 @@ async function updatePnpmWorkspace(versions) { // Handle both quoted ('npm:vitest@^...') and unquoted (npm:vitest@^...) forms content = content.replace( /vitest-dev: '?npm:vitest@\^[\d.]+(-[\w.]+)?'?/, - `vitest-dev: 'npm:vitest@^${versions.vitest}'`, + `vitest-dev: npm:vitest@^${versions.vitest}`, ); // Update tsdown in catalog (handle pre-release versions) From 5f03f87fb3e95fa8bb199edd6cd83a0aad0f6be7 Mon Sep 17 00:00:00 2001 From: MK Date: Mon, 13 Apr 2026 09:51:37 +0800 Subject: [PATCH 2/2] fix: simplify vitest-dev regex to not handle quotes --- .github/scripts/upgrade-deps.mjs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/scripts/upgrade-deps.mjs b/.github/scripts/upgrade-deps.mjs index 02491a4960..c0551bd19b 100644 --- a/.github/scripts/upgrade-deps.mjs +++ b/.github/scripts/upgrade-deps.mjs @@ -61,9 +61,8 @@ async function updatePnpmWorkspace(versions) { let content = fs.readFileSync(filePath, 'utf8'); // Update vitest-dev override (handle pre-release versions like -beta.1, -rc.0) - // Handle both quoted ('npm:vitest@^...') and unquoted (npm:vitest@^...) forms content = content.replace( - /vitest-dev: '?npm:vitest@\^[\d.]+(-[\w.]+)?'?/, + /vitest-dev: npm:vitest@\^[\d.]+(-[\w.]+)?/, `vitest-dev: npm:vitest@^${versions.vitest}`, );