refactor(editor): improve extraVsCodeSettings naming, type safety, and test coverage

Author: jong-kyung

packages/cli/src/create/bin.ts

@@ -796,7 +796,7 @@ Use \`vp create --list\` to list all available templates, or run \`vp create --h
       editorId: selectedEditor,
       interactive: options.interactive,
       silent: compactOutput,
-      additionalSettings: { 'npm.scriptRunner': 'vp' },
+      extraVsCodeSettings: { 'npm.scriptRunner': 'vp' },
     });
     resumeCreateProgress();
     workspaceInfo.rootDir = fullPath;

packages/cli/src/utils/__tests__/editor.spec.ts

@@ -49,7 +49,7 @@ describe('writeEditorConfigs', () => {
       editorId: 'vscode',
       interactive: false,
       silent: true,
-      additionalSettings: { 'npm.scriptRunner': 'vp' },
+      extraVsCodeSettings: { 'npm.scriptRunner': 'vp' },
     });
 
     const settings = JSON.parse(
@@ -84,7 +84,7 @@ describe('writeEditorConfigs', () => {
       editorId: 'vscode',
       interactive: false,
       silent: true,
-      additionalSettings: { 'npm.scriptRunner': 'vp' },
+      extraVsCodeSettings: { 'npm.scriptRunner': 'vp' },
     });
 
     const settings = JSON.parse(
@@ -104,6 +104,51 @@ describe('writeEditorConfigs', () => {
     expect(codeActions['source.fixAll.oxc']).toBe('explicit');
   });
 
+  it('does not apply extraVsCodeSettings to zed editor', async () => {
+    const projectRoot = createTempDir();
+
+    await writeEditorConfigs({
+      projectRoot,
+      editorId: 'zed',
+      interactive: false,
+      silent: true,
+      extraVsCodeSettings: { 'npm.scriptRunner': 'vp' },
+    });
+
+    const settings = JSON.parse(
+      fs.readFileSync(path.join(projectRoot, '.zed', 'settings.json'), 'utf8'),
+    ) as Record<string, unknown>;
+
+    expect(settings['npm.scriptRunner']).toBeUndefined();
+  });
+
+  it('preserves existing npm.scriptRunner during merge with extraVsCodeSettings', async () => {
+    const projectRoot = createTempDir();
+
+    const vscodeDir = path.join(projectRoot, '.vscode');
+    fs.mkdirSync(vscodeDir, { recursive: true });
+    fs.writeFileSync(
+      path.join(vscodeDir, 'settings.json'),
+      JSON.stringify({ 'npm.scriptRunner': 'npm' }),
+      'utf8',
+    );
+
+    await writeEditorConfigs({
+      projectRoot,
+      editorId: 'vscode',
+      interactive: false,
+      silent: true,
+      extraVsCodeSettings: { 'npm.scriptRunner': 'vp' },
+    });
+
+    const settings = JSON.parse(
+      fs.readFileSync(path.join(projectRoot, '.vscode', 'settings.json'), 'utf8'),
+    ) as Record<string, unknown>;
+
+    // deepMerge preserves existing keys — 'npm' is not overwritten by 'vp'
+    expect(settings['npm.scriptRunner']).toBe('npm');
+  });
+
   it('writes zed settings that align formatter config with vite.config.ts', async () => {
     const projectRoot = createTempDir();
 

packages/cli/src/utils/editor.ts

@@ -267,14 +267,14 @@ export async function writeEditorConfigs({
   interactive,
   conflictDecisions,
   silent = false,
-  additionalSettings,
+  extraVsCodeSettings,
 }: {
   projectRoot: string;
   editorId: EditorId | undefined;
   interactive: boolean;
   conflictDecisions?: Map<string, 'merge' | 'skip'>;
   silent?: boolean;
-  additionalSettings?: Record<string, unknown>;
+  extraVsCodeSettings?: Record<string, string>;
 }) {
   if (!editorId) {
     return;
@@ -290,8 +290,8 @@ export async function writeEditorConfigs({
 
   for (const [fileName, baseIncoming] of Object.entries(editorConfig.files)) {
     const incoming =
-      editorId === 'vscode' && fileName === 'settings.json' && additionalSettings
-        ? { ...baseIncoming, ...additionalSettings }
+      editorId === 'vscode' && fileName === 'settings.json' && extraVsCodeSettings
+        ? { ...extraVsCodeSettings, ...baseIncoming }
         : baseIncoming;
     const filePath = path.join(targetDir, fileName);