refactor: tighten visibility and avoid unnecessary clones in check module

- Revert resolve_and_build_command to private (only used within cli.rs)
- Narrow LintMessageKind and methods from pub(crate)/pub to pub(super)
- Make combine_output take ownership of CapturedCommandOutput to avoid
  cloning stdout/stderr strings on every call

Author: fengmk2

packages/cli/binding/src/check/analysis.rs

@@ -36,13 +36,13 @@ pub(super) struct LintFailure {
 }
 
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
-pub(crate) enum LintMessageKind {
+pub(super) enum LintMessageKind {
     LintOnly,
     LintAndTypeCheck,
 }
 
 impl LintMessageKind {
-    pub fn from_lint_config(lint_config: Option<&serde_json::Value>) -> Self {
+    pub(super) fn from_lint_config(lint_config: Option<&serde_json::Value>) -> Self {
         let type_check_enabled = lint_config
             .and_then(|config| config.get("options"))
             .and_then(|options| options.get("typeCheck"))
@@ -52,21 +52,21 @@ impl LintMessageKind {
         if type_check_enabled { Self::LintAndTypeCheck } else { Self::LintOnly }
     }
 
-    pub fn success_label(self) -> &'static str {
+    pub(super) fn success_label(self) -> &'static str {
         match self {
             Self::LintOnly => "Found no warnings or lint errors",
             Self::LintAndTypeCheck => "Found no warnings, lint errors, or type errors",
         }
     }
 
-    pub fn warning_heading(self) -> &'static str {
+    pub(super) fn warning_heading(self) -> &'static str {
         match self {
             Self::LintOnly => "Lint warnings found",
             Self::LintAndTypeCheck => "Lint or type warnings found",
         }
     }
 
-    pub fn issue_heading(self) -> &'static str {
+    pub(super) fn issue_heading(self) -> &'static str {
         match self {
             Self::LintOnly => "Lint issues found",
             Self::LintAndTypeCheck => "Lint or type issues found",

packages/cli/binding/src/check/mod.rs

@@ -61,9 +61,8 @@ pub(crate) async fn execute_check(
             false,
         )
         .await?;
-        status = captured.status;
-
-        let combined_output = combine_output(&captured);
+        let (fmt_status, combined_output) = combine_output(captured);
+        status = fmt_status;
 
         if !fix {
             match analyze_fmt_check_output(&combined_output) {
@@ -141,9 +140,8 @@ pub(crate) async fn execute_check(
             true,
         )
         .await?;
-        status = captured.status;
-
-        let combined_output = combine_output(&captured);
+        let (lint_status, combined_output) = combine_output(captured);
+        status = lint_status;
 
         match analyze_lint_output(&combined_output) {
             Some(Ok(success)) => {
@@ -209,9 +207,9 @@ pub(crate) async fn execute_check(
             false,
         )
         .await?;
-        status = captured.status;
+        let (refmt_status, combined_output) = combine_output(captured);
+        status = refmt_status;
         if status != ExitStatus::SUCCESS {
-            let combined_output = combine_output(&captured);
             print_error_block(
                 "Formatting could not finish after lint fixes",
                 &combined_output,
@@ -234,12 +232,13 @@ pub(crate) async fn execute_check(
 }
 
 /// Combine stdout and stderr from a captured command output.
-fn combine_output(captured: &CapturedCommandOutput) -> String {
-    if captured.stderr.is_empty() {
-        captured.stdout.clone()
+fn combine_output(captured: CapturedCommandOutput) -> (ExitStatus, String) {
+    let combined = if captured.stderr.is_empty() {
+        captured.stdout
     } else if captured.stdout.is_empty() {
-        captured.stderr.clone()
+        captured.stderr
     } else {
         format!("{}{}", captured.stdout, captured.stderr)
-    }
+    };
+    (captured.status, combined)
 }

packages/cli/binding/src/cli.rs

@@ -697,7 +697,7 @@ impl UserConfigLoader for VitePlusConfigLoader {
 }
 
 /// Resolve a subcommand into a prepared `tokio::process::Command`.
-pub(crate) async fn resolve_and_build_command(
+async fn resolve_and_build_command(
     resolver: &SubcommandResolver,
     subcommand: SynthesizableSubcommand,
     resolved_vite_config: Option<&ResolvedUniversalViteConfig>,