Skip to content

react-doctor: rename generic handler names — handleClick/handleChange → action verbs (51 warnings) #276

@bntvllnt

Description

@bntvllnt

Source

`npx react-doctor . --json` — 51 warnings, single rule `no-generic-handler-names`.

Why this matters

Generic names (`handleClick`, `onChange`, `handleSubmit`) hide intent. `handleSelectComponent` / `handleAddTag` / `handleClearFilter` self-document and improve grep / refactor.

Sample

  • `registry/default/timeline-scrubber/timeline-scrubber.tsx:277`
  • `registry/default/knowledge-check/knowledge-check.tsx:502`
  • `registry/default/relationship-inspector/relationship-inspector.tsx:113`
  • `registry/default/comment-pin/comment-pin.tsx:176`
  • `registry/default/jarvis-dock/jarvis-dock.tsx:89`
  • `registry/default/ai-artifact/ai-artifact.tsx:485,526,562,600`

Acceptance criteria

  • Rename all generic handlers to action-oriented names: `handle{Verb}{Object}`.
  • Pattern: `handleClick` → `handlePinClick` / `handleAddSlide` / `handleSelectArtifact`.
  • DOM event prop names (`onClick={handleX}`) stay generic — only handler definitions change.
  • `pnpm doctor` reports 0 generic-handler warnings.

Run

```bash
pnpm doctor --explain registry/default/ai-artifact/ai-artifact.tsx:485
```

Metadata

Metadata

Assignees

Labels

dxDeveloper experiencereact-doctorReported by react-doctor (codebase health)tech-debtRefactoring or cleanup

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions