[Bug] DrawPolygonByDraggingMode should not allow drawing with middle or right mouse buttons

[AnJ-K]

Module

• deck.gl-community/arrow-layers
• deck.gl-community/bing-maps
• deck.gl-community/editable-layers
• deck.gl-community/experimental
• deck.gl-community/graph-layers
• deck.gl-community/layers
• deck.gl-community/react
• deck.gl-community/react-graph-layer

Description

When using DrawPolygonByDraggingMode it is possible to draw the shape using middle mouse button and right mouse button.

Expected Behavior

It should not be possible to draw with middle or right mouse button. It is not expected, it makes it impossible to pan the map with middle mouse button while in this mode, and right click will likely open the context menu that will cover the canvas while drawing.

Steps to Reproduce

Create a editable layer with DrawPolygonByDraggingMode and try drawing with middle or right mouse button.

Small reproduction example:
https://stackblitz.com/edit/vitejs-vite-jh6kgn8t

Environment

• Framework version: deck.gl@9.2.8, deck.gl-community/editable-layers: 9.2.5
• Browser: Firefox 139.0.1, Chrome
• OS: Linux, Windows

Logs

No response

[AnJ-K]

I now noticed that for example DrawCircleFromCenterMode has the same behavior when dragToDraw is set to true.
Also edit modes seem to allow middle and right clicks in for example dragging a corner of a shape.

I think in such cases it should omit middle and right mouse buttons, and only allow drawing/editing with the left mouse button.

On my end I just applied a dirty npm patch for the modes that I need. I'm not sure if and where we could apply a global fix that would just disable those buttons everywhere.

[charlieforward9]

Bumped Stackblitz to latest dependencies, verified reproducibility and updated description.

I believe this has to do with how we handle click events in a very generalized way within this layer.

Some ideas:

• update the onEdit callback to have a editKey/editButton field with the way the user performed the edit. The client can decide whether to propogate the update to the state or not.
• add onClick, onContextMenu handlers that could wrap the onEdit callback?

This could use some more discussion @ibgreen @georgioskarnas