Merge pull request #217 from virtusize/bugfix/NSDK-408

NSDK-408 dublicated analytics events fix

Author: ObranS

CHANGES.md

@@ -10,6 +10,9 @@ Use list notation, and following prefixes:
 - Bugfix - when fixing any major bug
 - Docs - for any improvement to documentation
 
+### Changes:
+- Fix: Prevent send event userSawProduct when productValid = false or repeated product load
+
 ### 2.12.24
 - Fix: fixed VirtusizeInPageStandart view transalte issue
 

Virtusize/Sources/VirtusizeRepository.swift

@@ -52,6 +52,9 @@ internal class VirtusizeRepository: NSObject { // swiftlint:disable:this type_bo
 	/// Note: No lock needed - protected by task cancellation in Virtusize.load()
 	internal var serverStoreProductSet: Set<VirtusizeServerProduct> = []
 
+	/// The external product ID of the last product for which userSawProduct was sent
+	private var lastUserSawProductExternalId: String?
+
 	/// Insert into serverStoreProductSet
 	private func insertIntoProductSet(_ product: VirtusizeServerProduct) {
 		serverStoreProductSet.insert(product)
@@ -83,13 +86,7 @@ internal class VirtusizeRepository: NSObject { // swiftlint:disable:this type_bo
 		mutableProduct.productCheckData = product.productCheckData
         mutableProduct.imageURL = imageURL
 
-		// Send the API event where the user saw the product
-		Task { // should NOT be awaited, to not block the main flow
-			await VirtusizeAPIService.sendEvent(
-				VirtusizeEvent(name: .userSawProduct),
-				withContext: mutableProduct.jsonObject
-			)
-		}
+		let isNewProduct = mutableProduct.externalId != lastUserSawProductExternalId
 
 		guard mutableProduct.productCheckData?.productDataId != nil else {
             DispatchQueue.main.async {
@@ -102,6 +99,17 @@ internal class VirtusizeRepository: NSObject { // swiftlint:disable:this type_bo
 			return nil
 		}
 
+		if isNewProduct && mutableProduct.productCheckData?.validProduct == true {
+			lastUserSawProductExternalId = mutableProduct.externalId
+			// Send the API event where the user saw the product
+			Task { // should NOT be awaited, to not block the main flow
+				await VirtusizeAPIService.sendEvent(
+					VirtusizeEvent(name: .userSawProduct),
+					withContext: mutableProduct.jsonObject
+				)
+			}
+		}
+
 		if let sendImageToBackend = mutableProduct.productCheckData?.fetchMetaData,
 		   sendImageToBackend,
            imageURL != nil,
@@ -112,11 +120,13 @@ internal class VirtusizeRepository: NSObject { // swiftlint:disable:this type_bo
 		}
 
 		// Send the API event where the user saw the widget button
-		Task { // should NOT be awaited, to not block the main flow
-			await VirtusizeAPIService.sendEvent(
-				VirtusizeEvent(name: .userSawWidgetButton),
-				withContext: mutableProduct.jsonObject
-			)
+		if isNewProduct && mutableProduct.productCheckData?.validProduct == true {
+			Task { // should NOT be awaited, to not block the main flow
+				await VirtusizeAPIService.sendEvent(
+					VirtusizeEvent(name: .userSawWidgetButton),
+					withContext: mutableProduct.jsonObject
+				)
+			}
 		}
 
 		// Post notification on main thread