Feat/compose images check (#30)

Author: vidya381

internal/check/compose.go

@@ -73,3 +73,96 @@ func (c *ComposeCheck) Run(_ context.Context) Result {
 		Message: "all services are running",
 	}
 }
+
+type ComposeImageCheck struct {
+	runner func() ([]byte, error)
+}
+
+func (c *ComposeImageCheck) Name() string {
+	return "Docker Compose images pulled"
+}
+
+type composeImage struct {
+	ContainerName string `json:"ContainerName"`
+	Repository    string `json:"Repository"`
+	ID            string `json:"ID"`
+}
+
+func (c *ComposeImageCheck) Run(_ context.Context) Result {
+	run := c.runner
+	if run == nil {
+		run = func() ([]byte, error) {
+			return exec.Command("docker", "compose", "images", "--format", "json").Output()
+		}
+	}
+
+	out, err := run()
+	if err != nil {
+		return Result{
+			Name:    c.Name(),
+			Status:  StatusFail,
+			Message: "could not run docker compose images",
+			Fix:     "make sure Docker is running and you are in the project directory",
+		}
+	}
+
+	images, parseErr := parseComposeImages(out)
+	if parseErr != nil {
+		return Result{
+			Name:    c.Name(),
+			Status:  StatusFail,
+			Message: "could not parse docker compose images output",
+		}
+	}
+
+	var missing []string
+	for _, img := range images {
+		if img.Repository == "" || img.Repository == "<none>" || img.ID == "" {
+			missing = append(missing, img.ContainerName)
+		}
+	}
+
+	if len(missing) > 0 {
+		return Result{
+			Name:    c.Name(),
+			Status:  StatusFail,
+			Message: fmt.Sprintf("images not pulled for: %s", strings.Join(missing, ", ")),
+			Fix:     "run docker compose pull to pull all images",
+		}
+	}
+
+	return Result{
+		Name:    c.Name(),
+		Status:  StatusPass,
+		Message: "all service images are pulled",
+	}
+}
+
+func parseComposeImages(data []byte) ([]composeImage, error) {
+	data = bytes.TrimSpace(data)
+	if len(data) == 0 {
+		return nil, nil
+	}
+	// newer Docker versions output a JSON array; older versions output JSONL
+	if data[0] == '[' {
+		var images []composeImage
+		if err := json.Unmarshal(data, &images); err != nil {
+			return nil, err
+		}
+		return images, nil
+	}
+	var images []composeImage
+	scanner := bufio.NewScanner(bytes.NewReader(data))
+	for scanner.Scan() {
+		line := strings.TrimSpace(scanner.Text())
+		if line == "" {
+			continue
+		}
+		var img composeImage
+		if err := json.Unmarshal([]byte(line), &img); err != nil {
+			continue
+		}
+		images = append(images, img)
+	}
+	return images, nil
+}

internal/check/compose_test.go

@@ -3,6 +3,7 @@ package check
 import (
 	"context"
 	"errors"
+	"strings"
 	"testing"
 )
 
@@ -47,3 +48,67 @@ func TestComposeCheck_NoServices(t *testing.T) {
 		t.Errorf("expected pass, got %v: %s", result.Status, result.Message)
 	}
 }
+
+func TestComposeImageCheck_AllPulled(t *testing.T) {
+	c := &ComposeImageCheck{runner: func() ([]byte, error) {
+		return []byte(`[{"ContainerName":"app_web_1","Repository":"nginx","ID":"sha256:abc"}]`), nil
+	}}
+	result := c.Run(context.Background())
+	if result.Status != StatusPass {
+		t.Errorf("expected pass, got %v: %s", result.Status, result.Message)
+	}
+}
+
+func TestComposeImageCheck_MissingImage(t *testing.T) {
+	c := &ComposeImageCheck{runner: func() ([]byte, error) {
+		return []byte(`[{"ContainerName":"app_web_1","Repository":"","ID":""}]`), nil
+	}}
+	result := c.Run(context.Background())
+	if result.Status != StatusFail {
+		t.Errorf("expected fail, got %v", result.Status)
+	}
+	if !strings.Contains(result.Message, "app_web_1") {
+		t.Errorf("expected message to mention service name, got: %s", result.Message)
+	}
+}
+
+func TestComposeImageCheck_NoneRepository(t *testing.T) {
+	c := &ComposeImageCheck{runner: func() ([]byte, error) {
+		return []byte(`[{"ContainerName":"app_db_1","Repository":"<none>","ID":""}]`), nil
+	}}
+	result := c.Run(context.Background())
+	if result.Status != StatusFail {
+		t.Errorf("expected fail, got %v", result.Status)
+	}
+}
+
+func TestComposeImageCheck_JSONLFormat(t *testing.T) {
+	c := &ComposeImageCheck{runner: func() ([]byte, error) {
+		return []byte(`{"ContainerName":"app_web_1","Repository":"nginx","ID":"sha256:abc"}` + "\n" +
+			`{"ContainerName":"app_db_1","Repository":"postgres","ID":"sha256:def"}` + "\n"), nil
+	}}
+	result := c.Run(context.Background())
+	if result.Status != StatusPass {
+		t.Errorf("expected pass, got %v: %s", result.Status, result.Message)
+	}
+}
+
+func TestComposeImageCheck_CommandFails(t *testing.T) {
+	c := &ComposeImageCheck{runner: func() ([]byte, error) {
+		return nil, errors.New("docker not found")
+	}}
+	result := c.Run(context.Background())
+	if result.Status != StatusFail {
+		t.Errorf("expected fail, got %v", result.Status)
+	}
+}
+
+func TestComposeImageCheck_NoOutput(t *testing.T) {
+	c := &ComposeImageCheck{runner: func() ([]byte, error) {
+		return []byte(""), nil
+	}}
+	result := c.Run(context.Background())
+	if result.Status != StatusPass {
+		t.Errorf("expected pass, got %v: %s", result.Status, result.Message)
+	}
+}

internal/check/registry.go

@@ -46,6 +46,7 @@ func Build(stack detector.DetectedStack) []Check {
 	}
 	if stack.DockerCompose {
 		cs = append(cs, &ComposeCheck{})
+		cs = append(cs, &ComposeImageCheck{})
 	}
 	if stack.Postgres {
 		cs = append(cs, &PostgresCheck{URL: os.Getenv("DATABASE_URL")})