From 5e1ead3bad5a97215829525c863705e78c2ac14f Mon Sep 17 00:00:00 2001 From: Nicolas Palpacuer Date: Tue, 5 May 2026 18:37:48 -0400 Subject: [PATCH] RSDK-9718: fix tagger.proto go_package so descriptor registers under proto path The tagger.proto's go_package pointed at the upstream protoc-gen-gotag package, which registers a different file path (tagger/tagger.proto) than what consuming protos import (tagger/v1/tagger.proto). As a result, generated descriptors for app/v1/robot.proto, app/v1/app.proto, and app/mltraining/v1/ml_training.proto have a transitive dependency on tagger/v1/tagger.proto that is never registered in the running process, breaking gRPC reflection for any service whose descriptor chain reaches this file (notably viam.service.discovery.v1.DiscoveryService). Switch go_package to the regenerated go.viam.com/api/tagger/v1 package so its init() runs and registers tagger/v1/tagger.proto under the path its consumers expect. Regenerate dependents via mise r buf-go. Co-Authored-By: Claude Opus 4.7 (1M context) --- app/mltraining/v1/ml_training.pb.go | 2 +- app/v1/app.pb.go | 2 +- app/v1/robot.pb.go | 2 +- proto/viam/tagger/v1/tagger.proto | 2 +- tagger/v1/tagger.pb.go | 9 ++++----- 5 files changed, 8 insertions(+), 9 deletions(-) diff --git a/app/mltraining/v1/ml_training.pb.go b/app/mltraining/v1/ml_training.pb.go index 6bd1011ed..a588dff8d 100644 --- a/app/mltraining/v1/ml_training.pb.go +++ b/app/mltraining/v1/ml_training.pb.go @@ -7,7 +7,7 @@ package v1 import ( - _ "github.com/srikrsna/protoc-gen-gotag/tagger" + _ "go.viam.com/api/tagger/v1" status "google.golang.org/genproto/googleapis/rpc/status" protoreflect "google.golang.org/protobuf/reflect/protoreflect" protoimpl "google.golang.org/protobuf/runtime/protoimpl" diff --git a/app/v1/app.pb.go b/app/v1/app.pb.go index 685138a1d..4d9cfee09 100644 --- a/app/v1/app.pb.go +++ b/app/v1/app.pb.go @@ -7,10 +7,10 @@ package v1 import ( - _ "github.com/srikrsna/protoc-gen-gotag/tagger" v11 "go.viam.com/api/app/mltraining/v1" v12 "go.viam.com/api/app/packages/v1" v1 "go.viam.com/api/common/v1" + _ "go.viam.com/api/tagger/v1" protoreflect "google.golang.org/protobuf/reflect/protoreflect" protoimpl "google.golang.org/protobuf/runtime/protoimpl" structpb "google.golang.org/protobuf/types/known/structpb" diff --git a/app/v1/robot.pb.go b/app/v1/robot.pb.go index e7b90c579..58834ade9 100644 --- a/app/v1/robot.pb.go +++ b/app/v1/robot.pb.go @@ -7,8 +7,8 @@ package v1 import ( - _ "github.com/srikrsna/protoc-gen-gotag/tagger" v1 "go.viam.com/api/common/v1" + _ "go.viam.com/api/tagger/v1" protoreflect "google.golang.org/protobuf/reflect/protoreflect" protoimpl "google.golang.org/protobuf/runtime/protoimpl" durationpb "google.golang.org/protobuf/types/known/durationpb" diff --git a/proto/viam/tagger/v1/tagger.proto b/proto/viam/tagger/v1/tagger.proto index 7138d0371..7292b8287 100644 --- a/proto/viam/tagger/v1/tagger.proto +++ b/proto/viam/tagger/v1/tagger.proto @@ -4,7 +4,7 @@ package tagger.v1; import "google/protobuf/descriptor.proto"; -option go_package = "github.com/srikrsna/protoc-gen-gotag/tagger;tagger"; +option go_package = "go.viam.com/api/tagger/v1;tagger"; // Tags are applied at the field level extend google.protobuf.FieldOptions { diff --git a/tagger/v1/tagger.pb.go b/tagger/v1/tagger.pb.go index 5a7b9515c..2d09a4225 100644 --- a/tagger/v1/tagger.pb.go +++ b/tagger/v1/tagger.pb.go @@ -69,11 +69,10 @@ var file_tagger_v1_tagger_proto_rawDesc = []byte{ 0x65, 0x6f, 0x66, 0x5f, 0x74, 0x61, 0x67, 0x73, 0x12, 0x1d, 0x2e, 0x67, 0x6f, 0x6f, 0x67, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2e, 0x4f, 0x6e, 0x65, 0x6f, 0x66, 0x4f, 0x70, 0x74, 0x69, 0x6f, 0x6e, 0x73, 0x18, 0xc3, 0xe0, 0x33, 0x20, 0x01, 0x28, 0x09, 0x52, - 0x09, 0x6f, 0x6e, 0x65, 0x6f, 0x66, 0x54, 0x61, 0x67, 0x73, 0x42, 0x34, 0x5a, 0x32, 0x67, 0x69, - 0x74, 0x68, 0x75, 0x62, 0x2e, 0x63, 0x6f, 0x6d, 0x2f, 0x73, 0x72, 0x69, 0x6b, 0x72, 0x73, 0x6e, - 0x61, 0x2f, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x63, 0x2d, 0x67, 0x65, 0x6e, 0x2d, 0x67, 0x6f, 0x74, - 0x61, 0x67, 0x2f, 0x74, 0x61, 0x67, 0x67, 0x65, 0x72, 0x3b, 0x74, 0x61, 0x67, 0x67, 0x65, 0x72, - 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, + 0x09, 0x6f, 0x6e, 0x65, 0x6f, 0x66, 0x54, 0x61, 0x67, 0x73, 0x42, 0x22, 0x5a, 0x20, 0x67, 0x6f, + 0x2e, 0x76, 0x69, 0x61, 0x6d, 0x2e, 0x63, 0x6f, 0x6d, 0x2f, 0x61, 0x70, 0x69, 0x2f, 0x74, 0x61, + 0x67, 0x67, 0x65, 0x72, 0x2f, 0x76, 0x31, 0x3b, 0x74, 0x61, 0x67, 0x67, 0x65, 0x72, 0x62, 0x06, + 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, } var file_tagger_v1_tagger_proto_goTypes = []any{