removed unused parameter within the noc placement normalization factors update routine

Author: Srivat97

vpr/src/place/noc_place_utils.cpp

@@ -252,7 +252,7 @@ void recompute_noc_costs(double* new_noc_aggregate_bandwidth_cost, double* new_n
     return;
 }
 
-void update_noc_normalization_factors(t_placer_costs& costs, const t_placer_opts& placer_opts) {
+void update_noc_normalization_factors(t_placer_costs& costs) {
     //Prevent the norm factors from going to infinity
     costs.noc_aggregate_bandwidth_cost_norm = std::min(1 / costs.noc_aggregate_bandwidth_cost, MAX_INV_NOC_AGGREGATE_BANDWIDTH_COST);
     costs.noc_latency_cost_norm = std::min(1 / costs.noc_latency_cost, MAX_INV_NOC_LATENCY_COST);

vpr/src/place/noc_place_utils.h

@@ -263,17 +263,15 @@ void recompute_noc_costs(double* new_noc_aggregate_bandwidth_cost, double* new_n
 
 /**
  * @brief Updates all the cost normalization factors relevant to the NoC.
- * Also updates the placement cost depending on the placment mode.
  * Handles exceptional cases so that the normalization factors do not
  * reach INF.
  * This is intended to be used to initialize the normalization factors of
  * the NoC and also at the outer loop iteration of placement to 
  * balance the NoC costs with other placment cost parameters.
  * 
  * @param costs Contains the normalization factors which need to be updated
- * @param placer_opts Determines the placement mode
  */
-void update_noc_normalization_factors(t_placer_costs& costs, const t_placer_opts& placer_opts);
+void update_noc_normalization_factors(t_placer_costs& costs);
 
 /**
  * @brief Calculates the aggregate bandwidth of each traffic flow in the NoC

vpr/src/place/place.cpp

@@ -661,7 +661,7 @@ void try_place(const Netlist<>& net_list,
         costs.noc_latency_cost = comp_noc_latency_cost(noc_opts);
 
         // initialize all the noc normalization factors
-        update_noc_normalization_factors(costs, placer_opts);
+        update_noc_normalization_factors(costs);
     }
 
     // set the starting total placement cost
@@ -1960,7 +1960,7 @@ static void update_placement_cost_normalization_factors(t_placer_costs* costs, c
 
     // update the noc normalization factors if the palcement includes the NoC
     if (noc_opts.noc) {
-        update_noc_normalization_factors(*costs, placer_opts);
+        update_noc_normalization_factors(*costs);
     }
 
     // update the current total placement cost

vpr/test/test_noc_place_utils.cpp

@@ -1061,7 +1061,7 @@ TEST_CASE("test_update_noc_normalization_factors", "[noc_place_utils]") {
         costs.noc_latency_cost = 1.;
 
         // run the test function
-        update_noc_normalization_factors(costs, placer_opts);
+        update_noc_normalization_factors(costs);
 
         // verify the aggregate bandwidth normalized cost
         // this should not be +INF and instead trimmed
@@ -1072,7 +1072,7 @@ TEST_CASE("test_update_noc_normalization_factors", "[noc_place_utils]") {
         costs.noc_latency_cost = 0.;
 
         // run the test function
-        update_noc_normalization_factors(costs, placer_opts);
+        update_noc_normalization_factors(costs);
 
         // verify the latency normalized cost
         // this should not be +INF and instead trimmed
@@ -1083,7 +1083,7 @@ TEST_CASE("test_update_noc_normalization_factors", "[noc_place_utils]") {
         costs.noc_latency_cost = 0.;
 
         // run the test function
-        update_noc_normalization_factors(costs, placer_opts);
+        update_noc_normalization_factors(costs);
 
         // verify the aggregate bandwidth normalized cost
         // this should not be trimmed
@@ -1094,7 +1094,7 @@ TEST_CASE("test_update_noc_normalization_factors", "[noc_place_utils]") {
         costs.noc_latency_cost = 50.e-12;
 
         // run the test function
-        update_noc_normalization_factors(costs, placer_opts);
+        update_noc_normalization_factors(costs);
 
         // verify the latency normalized cost
         // this should not be trimmed
@@ -1105,7 +1105,7 @@ TEST_CASE("test_update_noc_normalization_factors", "[noc_place_utils]") {
         costs.noc_latency_cost = 999.e-15;
 
         // run the test function
-        update_noc_normalization_factors(costs, placer_opts);
+        update_noc_normalization_factors(costs);
 
         // verify the latency normalized cost
         // this should not be trimmed