Updated timing_fail_error flow

Author: jmah76

vpr/src/timing/timing_fail_error.cpp

@@ -11,21 +11,22 @@
 
 /* Represents whether or not VPR should fail if timing constraints aren't met. */
 static bool terminate_if_timing_fails = false;
-static std::string fail_timing_msg = "";
+
+/* True if negative final slack. */
+static bool failed_timing = "";
 
 void set_terminate_if_timing_fails(bool cmd_opt_terminate_if_timing_fails) {
     terminate_if_timing_fails = cmd_opt_terminate_if_timing_fails;
 }
 
 /* Checks if slack is negative, if routing is finished, and if user wants VPR flow to fail if their
- * design doesn't meet timingconstraints. If both conditions are true, the function adds details about
- * the negative slack to a string that will be printed when VPR throws an error.
+ * design doesn't meet timingconstraints. If both conditions are true, failed_timing is set to True.
  */
-void check_if_failed_timing_constraints(double& slack, std::string slack_name, std::string prefix) {
+void check_if_failed_timing_constraints(double& slack, std::string prefix) {
     // The error should only be thrown after routing. Checking that prefix == "Final" ensures that
     // only negative slacks found after routing are considered.
     if (terminate_if_timing_fails && slack < 0 && prefix == "Final ") {
-        fail_timing_msg = "\nDesign did not meet timing constraints.\nTiming failed and terminate_if_timing_fails set -- exiting";
+        failed_timing = true;
     }
     return;
 }
@@ -34,11 +35,9 @@ void check_if_failed_timing_constraints(double& slack, std::string slack_name, s
  * constraints. Called by print_timing_stats in main.cpp.
  */
 void error_if_timing_failed() {
-    // Every time a negative slack is found, it adds on to fail_timing_msg where it failed.
-    // If fail_timing_msg is empty, then no negative slacks were found.
-    if (fail_timing_msg != "") {
-        const char* msg = fail_timing_msg.c_str();
-        VPR_FATAL_ERROR(VPR_ERROR_TIMING, msg);
+    if (failed_timing) {
+        std::string msg = "\nDesign did not meet timing constraints.\nTiming failed and terminate_if_timing_fails set -- exiting";
+        VPR_FATAL_ERROR(VPR_ERROR_TIMING, msg.c_str());
     }
     return;
 }

vpr/src/timing/timing_fail_error.h

@@ -11,7 +11,7 @@
  * constraints. If both conditions are true, the function adds details about the negative slack to a string
  * that will be printed when VPR throws an error.
  */
-void check_if_failed_timing_constraints(double& slack, std::string slack_name, std::string prefix);
+void check_if_failed_timing_constraints(double& slack, std::string prefix);
 
 void error_if_timing_failed();
 

vpr/src/timing/timing_util.cpp

@@ -417,8 +417,8 @@ void print_setup_timing_summary(const tatum::TimingConstraints& constraints,
 
     VTR_LOG("\n");
 
-    check_if_failed_timing_constraints(setup_worst_neg_slack, "setup Worst", prefix);
-    check_if_failed_timing_constraints(setup_total_neg_slack, "setup Total", prefix);
+    check_if_failed_timing_constraints(setup_worst_neg_slack, prefix);
+    check_if_failed_timing_constraints(setup_total_neg_slack, prefix);
 }
 
 /*
@@ -646,8 +646,8 @@ void print_hold_timing_summary(const tatum::TimingConstraints& constraints, cons
     }
     VTR_LOG("\n");
 
-    check_if_failed_timing_constraints(hold_worst_neg_slack, "hold Worst", prefix);
-    check_if_failed_timing_constraints(hold_total_neg_slack, "hold Total", prefix);
+    check_if_failed_timing_constraints(hold_worst_neg_slack, prefix);
+    check_if_failed_timing_constraints(hold_total_neg_slack, prefix);
 }
 
 /*