remove std::vector<TelegramFramePtr> TelegramBuffer::take_telegram_frames()

Author: w0lek

vpr/src/server/telegrambuffer.cpp

@@ -65,12 +65,6 @@ void TelegramBuffer::take_telegram_frames(std::vector<comm::TelegramFramePtr>& r
     }
 }
 
-std::vector<comm::TelegramFramePtr> TelegramBuffer::take_telegram_frames() {
-    std::vector<comm::TelegramFramePtr> result;
-    take_telegram_frames(result);
-    return result;
-}
-
 void TelegramBuffer::take_errors(std::vector<std::string>& errors) {
     errors.reserve(errors.size() + m_errors.size());
     std::move(std::begin(m_errors), std::end(m_errors), std::back_inserter(errors));

vpr/src/server/telegrambuffer.h

@@ -58,13 +58,6 @@ class TelegramBuffer
      */
     void take_telegram_frames(std::vector<TelegramFramePtr>& frames);
 
-    /**
-     * @brief Extracts well-formed telegram frames from the internal byte buffer.
-     * 
-     * @return std::vector<TelegramFramePtr> A vector containing pointers to the extracted telegram frames.
-     */
-    std::vector<TelegramFramePtr> take_telegram_frames();
-
     /**
      * @brief Takes errors from the internal storage.
      *

vpr/test/test_server_telegrambuffer.cpp

@@ -40,7 +40,8 @@ TEST_CASE("test_server_telegrambuffer_oneOpened", "[vpr]") {
     buff.append(comm::ByteArray{"111"});
     buff.append(comm::ByteArray{"222"});
 
-    auto frames = buff.take_telegram_frames();
+    std::vector<comm::TelegramFramePtr> frames;
+    buff.take_telegram_frames(frames);
     REQUIRE(frames.size() == 0);
 
     REQUIRE(std::string_view{buff.data()} == "111222");
@@ -57,7 +58,8 @@ TEST_CASE("test_server_telegrambuffer_notFilledTelegramButWithPrependedRubish",
     tBuff.append(rubbish);
     tBuff.append(msgHeader.buffer());
 
-    auto frames = tBuff.take_telegram_frames();
+    std::vector<comm::TelegramFramePtr> frames;
+    tBuff.take_telegram_frames(frames);
     REQUIRE(0 == frames.size());
 
     REQUIRE(msgHeader.buffer() == tBuff.data()); // the rubbish prefix fragment will be absent here
@@ -83,7 +85,8 @@ TEST_CASE("test_server_telegrambuffer__oneFinishedOneOpened", "[vpr]")
     tBuff.append(t1);
     tBuff.append(t2);
 
-    auto frames = tBuff.take_telegram_frames();
+    std::vector<comm::TelegramFramePtr> frames;
+    tBuff.take_telegram_frames(frames);
     REQUIRE(1 == frames.size());
 
     REQUIRE(msgBody1 == frames[0]->body);
@@ -110,7 +113,8 @@ TEST_CASE("test_server_telegrambuffer_twoFinished", "[vpr]")
     tBuff.append(t1);
     tBuff.append(t2);
 
-    auto frames = tBuff.take_telegram_frames();
+    std::vector<comm::TelegramFramePtr> frames;
+    tBuff.take_telegram_frames(frames);
     REQUIRE(2 == frames.size());
 
     REQUIRE(msgBody1 == frames[0]->body);
@@ -137,7 +141,8 @@ TEST_CASE("test_server_telegrambuffer_clear", "[vpr]")
 
     tBuff.clear();
 
-    auto frames = tBuff.take_telegram_frames();
+    std::vector<comm::TelegramFramePtr> frames;
+    tBuff.take_telegram_frames(frames);
     REQUIRE(0 == frames.size());
 
     REQUIRE(comm::ByteArray{} == tBuff.data());