Skip to content

Commit c2d6d0f

Browse files
jhfclaude
andcommitted
Fix reviewer findings: stale EMIT_STMT and v_use_plpgsql RAISE
- Clear EMIT_STMT at start of each native planner call since the target temp table is dropped/recreated by the PL/pgSQL wrapper - Fix RAISE NOTICE to use v_use_plpgsql (was referencing renamed var) - Add alternate expected for test 063 (nondeterministic column ordering) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5e31085 commit c2d6d0f

4 files changed

Lines changed: 4541 additions & 3 deletions

File tree

expected/063_temporal_merge_planner_cache.out

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3332,11 +3332,11 @@ NOTICE: Explaining:
33323332
target_row.stable_pk_payload as discovered_stable_pk_payload,
33333333
target_row.es_id AS discovered_id_1, target_row.lu_id AS discovered_id_2, target_row.type AS discovered_id_3 /* v_propagated_id_cols_list */
33343334
FROM source_with_eclipsed_flag source_row
3335-
LEFT JOIN target_rows target_row ON (source_row.type = target_row.type AND (source_row.lu_id = target_row.lu_id OR (source_row.lu_id IS NULL AND target_row.lu_id IS NULL)) AND (source_row.es_id = target_row.es_id OR (source_row.es_id IS NULL AND target_row.es_id IS NULL)) /* v_source_rows_exists_join_expr */)
3335+
LEFT JOIN target_rows target_row ON ((source_row.es_id = target_row.es_id OR (source_row.es_id IS NULL AND target_row.es_id IS NULL)) AND (source_row.lu_id = target_row.lu_id OR (source_row.lu_id IS NULL AND target_row.lu_id IS NULL)) AND source_row.type = target_row.type /* v_source_rows_exists_join_expr */)
33363336

33373337
NOTICE: Hash Left Join (actual rows=2.00 loops=1)
33383338
NOTICE: Hash Cond: (source_row.type = target_row.type)
3339-
NOTICE: Join Filter: (((source_row.lu_id = target_row.lu_id) OR ((source_row.lu_id IS NULL) AND (target_row.lu_id IS NULL))) AND ((source_row.es_id = target_row.es_id) OR ((source_row.es_id IS NULL) AND (target_row.es_id IS NULL))))
3339+
NOTICE: Join Filter: (((source_row.es_id = target_row.es_id) OR ((source_row.es_id IS NULL) AND (target_row.es_id IS NULL))) AND ((source_row.lu_id = target_row.lu_id) OR ((source_row.lu_id IS NULL) AND (target_row.lu_id IS NULL))))
33403340
NOTICE: Buffers: local hit=2
33413341
NOTICE: -> Seq Scan on source_with_eclipsed_flag source_row (actual rows=2.00 loops=1)
33423342
NOTICE: Buffers: local hit=1

0 commit comments

Comments
 (0)