Revert "Snapshot Theme Toggling (#38)"

This reverts commit e9c3462.

Author: brody2002

Sources/FlowStack/FlowLink.swift

@@ -246,14 +246,13 @@ public struct FlowLink<Label>: View where Label: View {
     private var value: (any (Equatable & Hashable))?
     private var configuration: Configuration
 
+    @Environment(\.self) private var capturedEnvironment
+
     @Environment(\.flowPath) private var path
     @Environment(\.flowDepth) private var flowDepth
     @Environment(\.flowTransaction) private var transaction
     @Environment(\.flowAnimationDuration) private var flowDuration
 
-    @Environment(\.colorScheme) private var colorScheme
-    @Environment(\.self) private var fetchedEnvironment
-
     @State private var overrideAnchor: Anchor<CGRect>?
 
     @State private var size: CGSize?
@@ -262,11 +261,6 @@ public struct FlowLink<Label>: View where Label: View {
     @State var isShowing: Bool = true
     @State var buttonPressed: Bool = false
 
-    @State var environmentList: [EnvironmentValues] = []
-    @State private var snapshots: [ColorScheme: UIImage] = [:]
-    @State private var environment = EnvironmentValues()
-    @State private var refreshButton = UUID()
-
     /// Creates a flow link that presents the view corresponding to a value.
     ///
     /// When someone activates the flow link that this initializer
@@ -302,23 +296,29 @@ public struct FlowLink<Label>: View where Label: View {
         return path?.wrappedValue.elements.map(\.context?.linkDepth).contains(flowDepth) ?? false
     }
 
-    private func createSnapshot(colorScheme: ColorScheme) -> UIImage? {
+    @State private var snapshot: UIImage?
+
+    @MainActor
+    private func updateSnapshot() -> UIImage? {
+        guard snapshot == nil else { return snapshot }
+
         guard let size = size else { return nil }
 
         let frame = CGRect(origin: .zero, size: size)
-        environment = fetchedEnvironment
-        environment.colorScheme = colorScheme
 
         let controller = UIHostingController(
             rootView: label()
-                .environment(\.self, environment)
+                .transformEnvironment(\.self) { environment in
+                    environment = capturedEnvironment
+                }
                 .environment(\.opacityTransitionPercent, 1)
                 .ignoresSafeArea()
         )
-
         let view = controller.view
 
-        guard let view = view else { return nil}
+        guard let view = view else {
+            return nil
+        }
 
         view.bounds = CGRect(origin: .zero, size: size)
         view.backgroundColor = .clear
@@ -370,7 +370,7 @@ public struct FlowLink<Label>: View where Label: View {
                 }
                 Task {
                     if configuration.transitionFromSnapshot {
-                        context?.snapshot = snapshots[colorScheme]
+                        context?.snapshot = await updateSnapshot()
                     }
                     if let value = value {
                         withTransaction(transaction) {
@@ -379,8 +379,8 @@ public struct FlowLink<Label>: View where Label: View {
                     }
                 }
             }
-            .id(refreshButton)
     }
+
     public var body: some View {
         Group {
             if isContainedInPath && configuration.animateFromAnchor {
@@ -390,8 +390,8 @@ public struct FlowLink<Label>: View where Label: View {
                 if configuration.animateFromAnchor && overrideAnchor == nil {
                     button
                         .opacity(isShowing ? 1.0 : 0.0)
-                    /// (Workaround) Override an animation with an animation that does nothing
-                    /// Leaving a flowlayer too early can cause an un-wanted animation
+                        /// (Workaround) Override an animation with an animation that does nothing
+                        /// Leaving a flowlayer too early can cause an un-wanted animation
                         .ignoreAnimation()
                 } else if configuration.animateFromAnchor {
                     button
@@ -401,12 +401,6 @@ public struct FlowLink<Label>: View where Label: View {
                 }
             }
         }
-        .onChange(of: colorScheme) { newScheme in
-            refreshButton = UUID()
-            snapshots[newScheme]
-            path?.wrappedValue.updateSnapshots(from: newScheme)
-        }
-        .onAppear { initSnapshots() }
         .background(
             GeometryReader { proxy in
                 Color.clear
@@ -427,8 +421,7 @@ public struct FlowLink<Label>: View where Label: View {
             return PathContext(
                 anchor: configuration.animateFromAnchor ? anchor : nil,
                 overrideAnchor: configuration.animateFromAnchor ? overrideAnchor : nil,
-                snapshot: configuration.animateFromAnchor && configuration.transitionFromSnapshot ? snapshots[colorScheme] : nil,
-                snapshotDict: snapshots,
+                snapshot: configuration.animateFromAnchor && configuration.transitionFromSnapshot ? snapshot : nil,
                 linkDepth: flowDepth,
                 cornerRadius: configuration.cornerRadius,
                 cornerStyle: configuration.cornerStyle,
@@ -447,7 +440,6 @@ public struct FlowLink<Label>: View where Label: View {
             context?.overrideAnchor = overrideAnchor
         }
     }
-
     private func handleFlowLinkOpacity() {
         if isShowing == true, buttonPressed {
             isShowing = false
@@ -458,17 +450,6 @@ public struct FlowLink<Label>: View where Label: View {
             }}
         }
     }
-
-    private func initSnapshots() {
-        Task {
-            // Prevent Snapshot from being taken too early before Fetchable content loads
-            try? await Task.sleep(10000)
-                let lightImage = createSnapshot(colorScheme: .light)
-                let darkImage = createSnapshot(colorScheme: .dark)
-                snapshots[.light] = lightImage
-                snapshots[.dark] = darkImage
-        }
-    }
 }
 
 private struct IgnoreAnimationModifier: ViewModifier {

Sources/FlowStack/FlowPath.swift

@@ -28,7 +28,6 @@ struct PathContext: Equatable, Hashable {
     var overrideAnchor: Anchor<CGRect>?
 
     var snapshot: UIImage?
-    var snapshotDict: [ColorScheme: UIImage] = [:]
     var linkDepth: Int = 0
 
     var cornerRadius: CGFloat = 0
@@ -50,11 +49,13 @@ struct FlowElement: Equatable, Hashable {
     static func == (lhs: FlowElement, rhs: FlowElement) -> Bool {
         lhs.value.hashValue == rhs.value.hashValue &&
         _mangledTypeName(type(of: lhs.value)) == _mangledTypeName(type(of: rhs.value)) &&
+        lhs.context == rhs.context &&
         lhs.index == rhs.index
     }
 
     func hash(into hasher: inout Hasher) {
         hasher.combine(_mangledTypeName(type(of: value)))
+        hasher.combine(context)
         hasher.combine(index)
     }
 }
@@ -98,19 +99,6 @@ public struct FlowPath: Equatable, Hashable {
     public mutating func append<P>(_ newElement: P) where P: Hashable {
         self.append(newElement, context: nil)
     }
-
-    /// Adds a method to tell flow path to use the correct snapshot for the currently set colorScheme
-    /// - Parameters:
-    ///    - colorScheme: The new color scheme to be used for snapshots
-    public mutating func updateSnapshots(from colorScheme: ColorScheme) {
-        for i in elements.indices {
-            guard var context = elements[i].context else { continue }
-            if let newSnapshot = context.snapshotDict[colorScheme] {
-                context.snapshot = newSnapshot
-                elements[i].context?.snapshot = context.snapshot
-            }
-        }
-    }
 }
 
 struct FlowPathKey: EnvironmentKey {