chore: upgrade versions - remove stale deps

Author: meMuszr

build.gradle

@@ -1,14 +1,13 @@
+plugins {
+    id 'java'
+    id 'groovy'
+    id 'idea'
+    id 'eclipse'
+}
+
 group = 'com.veem'
 version = '1.0'
 
-apply plugin: 'java'
-apply plugin: 'groovy'
-apply plugin: 'idea'
-apply plugin: 'eclipse'
-
-sourceCompatibility = 1.8
-targetCompatibility = 1.8
-
 repositories {
     mavenCentral()
 }
@@ -17,25 +16,38 @@ configurations {
     extraLibs
 }
 
+java {
+    sourceCompatibility = JavaVersion.VERSION_17
+    targetCompatibility = JavaVersion.VERSION_17
+}
+
 dependencies {
-    compile 'com.fasterxml.jackson.core:jackson-databind:2.9.8',
-            'com.googlecode.json-simple:json-simple:1.1.1',
-            'com.squareup.retrofit2:retrofit:2.2.0',
-            'com.squareup.retrofit2:converter-jackson:2.2.0',
-            'com.squareup.okhttp3:logging-interceptor:3.12.0',
-            'com.neovisionaries:nv-i18n:1.21',
-            'org.projectlombok:lombok:1.18.4',
-            'org.slf4j:slf4j-api:1.7.25'
-    testCompile 'org.spockframework:spock-core:1.2-groovy-2.5'
+    implementation 'jakarta.xml.bind:jakarta.xml.bind-api:4.0.1'
+    implementation 'com.fasterxml.jackson.core:jackson-databind:2.16.1'
+    implementation 'com.squareup.retrofit2:retrofit:2.9.0'
+    implementation 'com.squareup.retrofit2:converter-jackson:2.9.0'
+    implementation 'com.squareup.okhttp3:logging-interceptor:4.12.0'
+    implementation 'com.neovisionaries:nv-i18n:1.29'
+    implementation 'org.slf4j:slf4j-api:2.0.12'
+
+    compileOnly 'org.projectlombok:lombok:1.18.30'
+    annotationProcessor 'org.projectlombok:lombok:1.18.30'
+
+    testCompileOnly 'org.projectlombok:lombok:1.18.30'
+    testAnnotationProcessor 'org.projectlombok:lombok:1.18.30'
+
+    testImplementation 'org.apache.groovy:groovy-json:4.0.19'
+    testImplementation 'org.spockframework:spock-core:2.3-groovy-4.0'
 }
 
-task copyExtraLibs(type: Copy) {
+tasks.register('copyExtraLibs', Copy) {
     from configurations.extraLibs
-    into tasks.jar.destinationDir
+    into tasks.jar.destinationDirectory
 }
 
 jar {
-    from configurations.compile.collect { it.isDirectory() ? it : zipTree(it) }
+    from configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) }
     exclude 'META-INF/*.SF', 'META-INF/*.DSA', 'META-INF/*.RSA', 'META-INF/*.MF', 'org/junit/**', 'junit'
+    duplicatesStrategy = DuplicatesStrategy.EXCLUDE
 
 }

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-2.11-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip

src/main/java/com/veem/client/AttachmentClient.java

@@ -79,7 +79,7 @@ public Attachment download(final Attachment attachment, final Path targetDirecto
         val targetFilePath = targetDirectory.toAbsolutePath().resolve(attachment.getName());
         if (Files.exists(targetFilePath))
         {
-            throw new VeemSdkException(String.format("%s already exists", targetFilePath.toString()));
+            throw new VeemSdkException(String.format("%s already exists", targetFilePath));
         }
         val responseBody = handleResponse(attachmentApi.download(
                 attachment.getName(), attachment.getReferenceId(), veemClient.authorization)::execute);
@@ -93,14 +93,14 @@ private static void prepareDirectory(final Path targetDirectory) throws VeemExce
         {
             if (!Files.isDirectory(targetDirectory))
             {
-                throw new VeemSdkException(String.format("%s is not a directory", targetDirectory.toString()));
+                throw new VeemSdkException(String.format("%s is not a directory", targetDirectory));
             }
         }
         else
         {
             if (!targetDirectory.toFile().mkdirs())
             {
-                throw new VeemSdkException(String.format("Unable to create director %s", targetDirectory.toString()));
+                throw new VeemSdkException(String.format("Unable to create director %s", targetDirectory));
             }
         }
     }
@@ -114,7 +114,7 @@ private static void writeFile(final Path targetFilePath, final ResponseBody resp
         catch (IOException e)
         {
             throw new VeemSdkException(e, String.format("The downloaded file could not be saved to %s",
-                    targetFilePath.toString()));
+                targetFilePath));
         }
     }
 }

src/main/java/com/veem/client/ResponseHandler.java

@@ -2,6 +2,7 @@
 
 import static java.util.Optional.ofNullable;
 
+import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.veem.exceptions.VeemBadRequestException;
 import com.veem.exceptions.VeemConflictException;
@@ -14,8 +15,6 @@
 import com.veem.exceptions.VeemUnauthorizedException;
 import lombok.extern.slf4j.Slf4j;
 import lombok.val;
-import org.json.simple.JSONObject;
-import org.json.simple.JSONValue;
 import retrofit2.Response;
 
 import java.io.IOException;
@@ -114,10 +113,10 @@ private static String extractError(final Response<?> response, final String erro
         String error;
         try
         {
-            val errorResponse = (JSONObject) JSONValue.parse(errorBody);
+            val errorResponse = MAPPER.readTree(errorBody);
             error = ofNullable(errorResponse)
                 .map(er -> er.get("message"))
-                .map(Object::toString)
+                .map(JsonNode::asText)
                 .orElseThrow(RuntimeException::new);
             log.error(error);
         }

src/main/java/com/veem/exceptions/VeemErrorResponse.java

@@ -7,7 +7,7 @@
 import lombok.NoArgsConstructor;
 import lombok.Setter;
 
-import javax.xml.bind.annotation.XmlRootElement;
+import jakarta.xml.bind.annotation.XmlRootElement;
 import java.util.Date;
 
 /**