Skip to content

Commit ee0a2fe

Browse files
ci: Lift constraints of installable (NVIDIA-NeMo#12562)
* ci: Lift constraints of installable Signed-off-by: oliver könig <okoenig@nvidia.com> * bump torch Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * remove macOS x86_64 Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add nemo run Signed-off-by: oliver könig <okoenig@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * will this work?:P Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * remove nemo_run Signed-off-by: oliver könig <okoenig@nvidia.com> * mcore Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> --------- Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 9c15a35 commit ee0a2fe

5 files changed

Lines changed: 4 additions & 25 deletions

File tree

.github/workflows/install-test.yml

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
os: [macos-latest, macos-13]
19+
os: [macos-latest]
2020
python: ["3.10", "3.11", "3.12"]
2121
installer: ["pip-install", "nemo-install"]
2222
steps:
@@ -44,18 +44,7 @@ jobs:
4444
bash reinstall.sh --library all --mode install
4545
fi
4646
47-
- name: Run LLM example
48-
if: ${{ matrix.installer == 'nemo-install' && matrix.python != '3.12' }}
49-
run: |
50-
# This is guarded since it requires nemo-run. We expect Nemo-run to be
51-
# available on PyPi with 25.04.
52-
53-
pip install jupyter nbconvert
54-
jupyter nbconvert --to script examples/llm/pretrain/pretrain.ipynb
55-
python examples/llm/pretrain/pretrain.py
56-
5747
- name: Run import checks
58-
if: ${{ matrix.os != 'macos-13' }}
5948
run: |
6049
# Run import checks
6150
for collection in "asr" "tts"; do
@@ -92,16 +81,6 @@ jobs:
9281
bash reinstall.sh --library all --mode install
9382
fi
9483
95-
- name: Run LLM example
96-
if: ${{ matrix.installer == 'nemo-install' }}
97-
run: |
98-
# This is guarded since it requires nemo-run. We expect Nemo-run to be
99-
# available on PyPi with 25.04.
100-
101-
pip install jupyter nbconvert
102-
jupyter nbconvert --to script examples/llm/pretrain/pretrain.ipynb
103-
python examples/llm/pretrain/pretrain.py
104-
10584
- name: Run import checks
10685
run: |
10786
# Run import checks

reinstall.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@ nemo() {
177177

178178
DEPS=(
179179
"sox" # requires numpy to be there @URL: https://github.com/marl/pysox/issues/167
180+
"llama-index==0.10.43" # incompatible with nvidia-pytriton
180181
"ctc_segmentation==1.7.1 ; (platform_machine == 'x86_64' and platform_system != 'Darwin')" # requires numpy<2.0.0 to be installed before
181-
"nemo_run@git+https://github.com/NVIDIA/NeMo-Run.git@f07f44688e42e5500bf28ff83dd3e0f4bead0c8d"
182182
)
183183

184184
if [[ -n "${NVIDIA_PYTORCH_VERSION}" ]]; then

requirements/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"megatron-lm": {
1313
"repo": "https://github.com/NVIDIA/Megatron-LM",
14-
"ref": "791b70e031dc6905f77e29c25f1e2ac5b8dd4870"
14+
"ref": "aa6207e2da6bca789375f591c9124aa408d2509a"
1515
}
1616
},
1717
"pypi-dependencies": {}

requirements/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
huggingface_hub>=0.24
2+
nemo_run
23
numba==0.61.0
34
numpy>=1.22,<2.0.0
45
onnx>=1.7.0

requirements/requirements_nlp.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ gdown
88
h5py
99
ijson
1010
jieba
11-
llama-index==0.10.43
1211
markdown2
1312
matplotlib>=3.3.2
1413
megatron_core

0 commit comments

Comments
 (0)