“squashfuse --version” exits unsuccessfully with code 254

[reidpr]

For example:

$ squashfuse --version
squashfuse 0.6.1 (c) 2012 Dave Vasilevsky

Usage: squashfuse [options] ARCHIVE MOUNTPOINT

squashfuse options:
    -o offset=N            offset N bytes into ARCHIVE to mount
    -o subdir=PATH         mount subdirectory PATH of ARCHIVE
    -o notify_pipe=PATH    named pipe that will receive 's' (success)
                           or 'f' (failure) when the mountpoint is ready

Selection of FUSE options:
    -h   --help            print help
    -V   --version         print version
    -d   -o debug          enable debug output (implies -f)
    -f                     foreground operation
    -o allow_other         allow access by other users
    -o allow_root          allow access by the superuser
$ echo $?
254

I would expect an exit code of zero, since the program correctly did what it was asked.

The use case is CI. I have squashfuse --version in my CI job so I can see in the log what version we got (I’m building the latest tagged version).

[vasi]

This makes sense, I'd accept a PR.

[reidpr]

OK, thanks. I looked briefly and it wasn’t clear to me where the command line options are being parsed, or what prints the version number (I did find the usage function). Can you point me to where that happens?

[vasi]

sqfs_opt_proc ends up seeing these: https://github.com/vasi/squashfuse/blob/master/fuseprivate.c#L133

Right now we just completely ignore the --version flag, and it ends up failing because there's no image or mountpoint passed! Probably instead we should add something in sqfs_opts to indicate the user wants to see the version.