[HIGH] Audit notification layer across all app states and features

[variablefate]

Problem

Notifications are behaving inconsistently across different app states and features. Several observed issues:

• Notifications saying "Starting..." when nothing is happening
• Ride-related notifications persisting after a ride has ended
• Unclear which notifications should fire (and when they should be hidden) across the matrix of app states

Scope

Full audit needed across all notification scenarios:

Driver app:

• Offline
• Online (Available)
• RoadFlare Only mode
• On ride (all stages: offer received, accepted, pickup, in-progress, completed)
• Ride cancellation (by rider or driver)

Rider app:

• Idle
• Waiting for acceptance (direct, broadcast, RoadFlare, batch)
• Driver accepted
• On ride (all stages: confirmed, pickup, in-progress, completed)
• Ride cancellation (by rider or driver)

RoadFlare-specific:

• New follower request
• Follower approved / key sent
• Location broadcasting active

Expected Outcome

• Each notification fires at the correct time for its feature
• Notifications are dismissed when no longer relevant
• Sound/vibration behavior is appropriate per notification type
• No phantom or stale notifications in any state transition