fix for woody errors processing (#39)

Co-authored-by: ttt161 <losto@nix>

Author: ttt161

config/sys.config

@@ -87,7 +87,10 @@
                         }
                 }
             ]}
-        ]}
+        ]},
+
+        %% optional, default true
+        {migration_enabled, true}
     ]},
 
     %%

src/prg_namespace_sup.erl

@@ -17,7 +17,12 @@
 -spec start_link({namespace_id(), namespace_opts()}) ->
     {ok, Pid :: pid()} | ignore | {error, Reason :: term()}.
 start_link({NsId, #{storage := StorageOpts}} = NS) ->
-    ok = prg_storage:db_init(StorageOpts, NsId),
+    case application:get_env(progressor, migration_enabled, true) of
+        true ->
+            ok = prg_storage:db_init(StorageOpts, NsId);
+        false ->
+            ok
+    end,
     RegName = prg_utils:registered_name(NsId, "_namespace_sup"),
     supervisor:start_link({local, RegName}, ?MODULE, NS).
 

src/prg_worker.erl

@@ -570,12 +570,16 @@ extract_task_type({TaskType, _}) ->
 
 check_retryable(TaskHeader, #{last_retry_interval := LastInterval} = Task, RetryPolicy, Error) ->
     Now = erlang:system_time(second),
+    ProcessId = maps:get(process_id, Task),
     Timeout =
         case LastInterval =:= 0 of
             true -> maps:get(initial_timeout, RetryPolicy);
             false -> trunc(LastInterval * maps:get(backoff_coefficient, RetryPolicy))
         end,
     Attempts = maps:get(attempts_count, Task) + 1,
+    logger:info("check retryable ~p for error: ~p, last retry interval: ~p sec, attempt: ~p", [
+        ProcessId, Error, LastInterval, Attempts
+    ]),
     case is_retryable(Error, TaskHeader, RetryPolicy, Timeout, Attempts) of
         true ->
             maps:with(
@@ -601,7 +605,7 @@ check_retryable(TaskHeader, #{last_retry_interval := LastInterval} = Task, Retry
     end.
 
 %% machinegun legacy
--define(WOODY_ERROR(Class), {exception, _, {woody_error, Class, _}}).
+-define(WOODY_ERROR(Class), {exception, _, {woody_error, {_, Class, _}}}).
 -define(TEST_POLICY(Error, RetryPolicy, Timeout, Attempts),
     (Timeout < maps:get(max_timeout, RetryPolicy, infinity) andalso
         Attempts < maps:get(max_attempts, RetryPolicy, infinity) andalso

test/prg_base_SUITE.erl

@@ -578,7 +578,7 @@ error_after_max_retries_test(C) ->
     4 = expect_steps_counter(4),
     timer:sleep(?AWAIT_TIMEOUT(C)),
     {ok, #{
-        detail := <<"retry_this">>,
+        detail := <<"{exception,error,{woody_error,{external,result_unknown,<<\"closed\">>}}}">>,
         history := [],
         process_id := Id,
         status := <<"error">>
@@ -1220,7 +1220,7 @@ mock_processor(error_after_max_retries_test = TestCase) ->
         ({timeout, <<>>, #{history := []} = _Process}, _Opts, _Ctx) ->
             %% must be 3 attempts
             Self ! iterate,
-            {error, retry_this}
+            erlang:raise(error, {woody_error, {external, result_unknown, <<"closed">>}}, [])
     end,
     mock_processor(TestCase, MockProcessor);
 %%