From 9c499cb65cae752d42bc370a81e8c4ddbb155385 Mon Sep 17 00:00:00 2001 From: Rustem Shaydullin Date: Tue, 31 Oct 2023 22:05:00 +0500 Subject: [PATCH 1/3] Get rid of codecov --- .github/workflows/erlang-parallel-build.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/erlang-parallel-build.yml b/.github/workflows/erlang-parallel-build.yml index 0443f4e..aec7152 100644 --- a/.github/workflows/erlang-parallel-build.yml +++ b/.github/workflows/erlang-parallel-build.yml @@ -268,16 +268,9 @@ jobs: if: ${{ inputs.upload-coverage == true && inputs.use-coveralls == true }} run: rebar3 lcov convert - - name: Upload coverage statistics (codecov) - if: ${{ inputs.upload-coverage == true }} - uses: codecov/codecov-action@v3 - with: - fail_ci_if_error: true - files: _build/test/covertool/*.covertool.xml - - name: Upload coverage statistics (coveralls) if: ${{ inputs.upload-coverage == true && inputs.use-coveralls == true }} - uses: coverallsapp/github-action@1.1.3 + uses: coverallsapp/github-action@v2.2.3 with: path-to-lcov: _build/test/lcov/lcov.info github-token: ${{ secrets.GITHUB_TOKEN }} From e0676818ed5b9d2caf1bf2374efe920d758e36a9 Mon Sep 17 00:00:00 2001 From: Rustem Shaydullin Date: Tue, 31 Oct 2023 22:05:47 +0500 Subject: [PATCH 2/3] Get rid of codecov in simple too --- .github/workflows/erlang-simple-build.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/erlang-simple-build.yml b/.github/workflows/erlang-simple-build.yml index 820c7ee..091f0c5 100644 --- a/.github/workflows/erlang-simple-build.yml +++ b/.github/workflows/erlang-simple-build.yml @@ -154,9 +154,9 @@ jobs: if: ${{ inputs.run-eunit == true || inputs.run-common-test == true }} run: rebar3 covertool generate - - name: Upload coverage statistics - if: ${{ inputs.run-eunit == true || inputs.run-common-test == true }} - uses: codecov/codecov-action@v3 + - name: Upload coverage statistics (coveralls) + if: ${{ inputs.upload-coverage == true && inputs.use-coveralls == true }} + uses: coverallsapp/github-action@v2.2.3 with: - fail_ci_if_error: true - files: _build/test/covertool/*.covertool.xml + path-to-lcov: _build/test/lcov/lcov.info + github-token: ${{ secrets.GITHUB_TOKEN }} From f92537c551c7879965a7299959cdbffb9418e82e Mon Sep 17 00:00:00 2001 From: Rustem Shaydullin Date: Tue, 31 Oct 2023 22:19:16 +0500 Subject: [PATCH 3/3] Get rid of extra variable --- .github/workflows/erlang-parallel-build.yml | 13 ++----------- .github/workflows/erlang-simple-build.yml | 2 +- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/.github/workflows/erlang-parallel-build.yml b/.github/workflows/erlang-parallel-build.yml index aec7152..0220b15 100644 --- a/.github/workflows/erlang-parallel-build.yml +++ b/.github/workflows/erlang-parallel-build.yml @@ -56,11 +56,6 @@ on: required: false default: true type: boolean - use-coveralls: - description: 'Use coveralls for code coverage analysis.' - required: false - default: false - type: boolean # Workflow env cache-version: description: 'Cache version. Only change this if you *need* to reset build caches.' @@ -260,16 +255,12 @@ jobs: name: ct-logs path: _build/test/logs - - name: Run test coverage conversion (covertool) - if: ${{ inputs.upload-coverage == true }} - run: rebar3 covertool generate - - name: Run test coverage conversion (lcov) - if: ${{ inputs.upload-coverage == true && inputs.use-coveralls == true }} + if: ${{ inputs.upload-coverage == true }} run: rebar3 lcov convert - name: Upload coverage statistics (coveralls) - if: ${{ inputs.upload-coverage == true && inputs.use-coveralls == true }} + if: ${{ inputs.upload-coverage == true }} uses: coverallsapp/github-action@v2.2.3 with: path-to-lcov: _build/test/lcov/lcov.info diff --git a/.github/workflows/erlang-simple-build.yml b/.github/workflows/erlang-simple-build.yml index 091f0c5..8a31b89 100644 --- a/.github/workflows/erlang-simple-build.yml +++ b/.github/workflows/erlang-simple-build.yml @@ -155,7 +155,7 @@ jobs: run: rebar3 covertool generate - name: Upload coverage statistics (coveralls) - if: ${{ inputs.upload-coverage == true && inputs.use-coveralls == true }} + if: ${{ inputs.upload-coverage == true }} uses: coverallsapp/github-action@v2.2.3 with: path-to-lcov: _build/test/lcov/lcov.info