Skip to content

Commit e832345

Browse files
committed
Now resourceTrackingMethod defaults to "annotation"
1 parent a0a04bc commit e832345

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ This chart is used to set up the basic building blocks in [Validated Patterns](h
88

99
### Notable changes
1010

11+
* v0.9.44: Default value of `resourceTrackingMethod` is now `annotation`
12+
* v0.9.43: Add support to `env`, `volumes` and `volumeMounts` in repository server
1113
* v0.9.38: Ensure sharedValueFiles and extraValueFiles are always prefixed with $patternref
1214
* v0.9.37: Use global.patternDelete value set by patterns operator when patterns are deleted
1315
* v0.9.32: Add labels and annotations to operatorgroups when included in namespaces
@@ -44,7 +46,7 @@ This chart is used to set up the basic building blocks in [Validated Patterns](h
4446
| clusterGroup.argoCD.resourceHealthChecks[1].check | string | `"local health_status = {}\n\nhealth_status.status = \"Progressing\"\nhealth_status.message = \"Waiting for InferenceService to report status...\"\n\nif obj.status ~= nil then\n\n local progressing = false\n local degraded = false\n local status_false = 0\n local status_unknown = 0\n local msg = \"\"\n\n if obj.status.modelStatus ~= nil then\n if obj.status.modelStatus.transitionStatus ~= \"UpToDate\" then\n if obj.status.modelStatus.transitionStatus == \"InProgress\" then\n progressing = true\n else\n degraded = true\n end\n msg = msg .. \"0: transitionStatus | \" .. obj.status.modelStatus.transitionStatus\n end\n end\n\n if obj.status.conditions ~= nil then\n for i, condition in pairs(obj.status.conditions) do\n\n -- A condition is healthy if its status is True.\n -- However, for the 'Stopped' condition, a 'False' status is the healthy state.\n local is_healthy_condition = (condition.status == \"True\")\n if condition.type == \"Stopped\" then\n is_healthy_condition = (condition.status == \"False\")\n end\n\n if not is_healthy_condition then\n -- This condition represents a problem, so update counters and the message.\n if condition.status == \"Unknown\" then\n status_unknown = status_unknown + 1\n else\n status_false = status_false + 1\n end\n\n msg = msg .. \" | \" .. i .. \": \" .. condition.type .. \" | \" .. condition.status\n if condition.reason ~= nil and condition.reason ~= \"\" then\n msg = msg .. \" | \" .. condition.reason\n end\n if condition.message ~= nil and condition.message ~= \"\" then\n msg = msg .. \" | \" .. condition.message\n end\n end\n\n end\n\n if progressing == false and degraded == false and status_unknown == 0 and status_false == 0 then\n health_status.status = \"Healthy\"\n msg = \"InferenceService is healthy.\"\n elseif degraded == false and status_unknown >= 0 then\n health_status.status = \"Progressing\"\n else\n health_status.status = \"Degraded\"\n end\n\n health_status.message = msg\n end\nend\n\nreturn health_status\n"` | |
4547
| clusterGroup.argoCD.resourceHealthChecks[1].group | string | `"serving.kserve.io"` | |
4648
| clusterGroup.argoCD.resourceHealthChecks[1].kind | string | `"InferenceService"` | |
47-
| clusterGroup.argoCD.resourceTrackingMethod | string | `"label"` | |
49+
| clusterGroup.argoCD.resourceTrackingMethod | string | `"annotation"` | |
4850
| clusterGroup.argoCD.volumeMounts | list | `[]` | |
4951
| clusterGroup.argoCD.volumes | list | `[]` | |
5052
| clusterGroup.extraObjects | object | `{}` | |

README.md.gotmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This chart is used to set up the basic building blocks in [Validated Patterns](h
1010
### Notable changes
1111

1212
* v0.9.44: Default value of `resourceTrackingMethod` is now `annotation`
13-
* v0.9.43: Add support to `env`, `volumes` and `volumeMounts` in repo server
13+
* v0.9.43: Add support to `env`, `volumes` and `volumeMounts` in repository server
1414
* v0.9.38: Ensure sharedValueFiles and extraValueFiles are always prefixed with $patternref
1515
* v0.9.37: Use global.patternDelete value set by patterns operator when patterns are deleted
1616
* v0.9.32: Add labels and annotations to operatorgroups when included in namespaces

values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ clusterGroup:
3535
volumeMounts: []
3636
configManagementPlugins: []
3737
# resource tracking can be set to annotation, label, or annotation+label
38-
resourceTrackingMethod: label
38+
resourceTrackingMethod: annotation
3939
resourceHealthChecks:
4040
# Adding health checks to argocd to prevent pvc resources
4141
# that aren't bound state from blocking deployments

0 commit comments

Comments
 (0)