Skip to content

onValid function passed to $submit can be called twice when using async validations #52

@misogl

Description

@misogl

I'm using react-custom-validation@0.5.7 and react@16.3.1.

This happens when submit occurs while the validation result is still undetermined.

The following events happen in the library:

  1. dispatchUpdate is called from setTimeout
  2. form is valid so onValid gets called and changes the redux state
  3. change in redux state causes render of the parent of validate form
  4. this causes call of componentWillReceiveProps in validated HOC
  5. dispatchUpdate is called again but the register is still in submitting state (call of onValid has not finished yet)

I was able to reproduce this issue only when running cypress tests as the async validation is quite fast.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions