fix: restore tag navigation and fix navbar filter refresh #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore tag element background color and navigation in FeedItemView - Add tag navigation to RecentItemView (最近浏览) - Fix UserFeedPage tag crash by adding missing tagId parameter - Fix navbar title not updating when filter menu selection changes by moving TopBar outside TabView content - Unify tag styling across all list views 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses tag navigation functionality and fixes a navbar title update issue in the V2er iOS app. The changes restore tag element interactivity and styling while solving a SwiftUI reactivity problem.
Key Changes:
- Moved TopBar outside TabView in MainPage to ensure immediate UI updates when filter selection changes
- Added tag navigation to all feed list views (FeedItemView, RecentItemView, UserFeedPage) by wrapping tag elements in NavigationLink
- Fixed crash in UserFeedPage by adding missing tagId parameter to TagDetailPage navigation
- Unified tag styling across all list views with consistent colors, padding, and dark mode support
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| V2er/View/Widget/TopBar.swift | Added explicit feedFilterTab parameter to trigger SwiftUI re-rendering when filter changes; updated title computation logic and preview |
| V2er/View/MainPage.swift | Moved TopBar outside TabView into a VStack wrapper to ensure immediate reactivity; removed obsolete pageWithTopBar helper function |
| V2er/View/Feed/FeedItemView.swift | Wrapped tag text in NavigationLink with tagId parameter; applied unified styling with background color and proper padding |
| V2er/View/Me/MyRecentPage.swift | Added NavigationLink for tag navigation in RecentItemView; applied unified tag styling consistent with other views |
| V2er/View/Me/UserFeedPage.swift | Fixed crash by adding missing tagId parameter to TagDetailPage; applied unified tag styling |
Code Coverage Report ❌Current coverage: 27.85% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code