feat: add splash screen with centered logo #81

graycreate · 2025-12-01T10:59:39Z

Summary

Add LaunchScreen.storyboard with centered V2er logo
Add SplashBackground and SplashLogoColor color sets with light/dark mode support
Colors match Android app implementation (white/dark gray background, contrasting logo)

Test plan

Build and run the app on simulator
Verify splash screen displays with centered logo
Test light mode appearance (white background, dark logo)
Test dark mode appearance (dark background, white logo)

🤖 Generated with Claude Code

Add LaunchScreen.storyboard with: - Centered V2er logo (100x100) - SplashBackground color (white/dark gray for light/dark mode) - SplashLogoColor for logo tint (matches Android implementation) Colors match Android app: - Light mode: white background (#FFFFFF), dark logo (#111214) - Dark mode: dark background (#111214), white logo (#FFFFFF) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull request overview

This PR adds a native iOS splash screen (launch screen) to the V2er app with a centered logo that adapts to light and dark mode appearances. The implementation uses a LaunchScreen.storyboard with proper Auto Layout constraints and named color assets for theme support.

Key changes:

New LaunchScreen.storyboard with centered 100x100pt logo using Auto Layout
Two named color sets (SplashBackground and SplashLogoColor) with light/dark mode variants
SplashLogo image asset configured as a template for tinting

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
V2er/LaunchScreen.storyboard	New launch screen storyboard with centered imageView using Auto Layout constraints and named color references
V2er/Assets.xcassets/SplashLogo.imageset/Contents.json	Image asset configuration with template rendering and vector preservation properties
V2er/Assets.xcassets/SplashLogo.imageset/splash_logo.png	1024x1024px PNG logo image (binary file)
V2er/Assets.xcassets/Colors/SplashLogoColor.colorset/Contents.json	Logo tint color: dark gray (light mode) / white (dark mode)
V2er/Assets.xcassets/Colors/SplashBackground.colorset/Contents.json	Background color: white (light mode) / dark gray (dark mode)
V2er.xcodeproj/project.pbxproj	Xcode project file updates to include LaunchScreen.storyboard in resources

Copilot · 2025-12-01T11:02:31Z

V2er/LaunchScreen.storyboard

+        <namedColor name="SplashBackground">
+            <color red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
+        </namedColor>
+        <namedColor name="SplashLogoColor">
+            <color red="0.066999999999999993" green="0.070999999999999994" blue="0.078" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
+        </namedColor>


The storyboard includes hardcoded RGB color values in the resources section (lines 44-49) that duplicate the color definitions from the named color sets. This creates a discrepancy where:

The view references named colors SplashBackground and SplashLogoColor (lines 22, 30) which support light/dark mode

But the <resources> section defines fallback RGB values that only represent the light mode colors

This inconsistency could cause issues if the named color assets are not found. Consider removing the hardcoded RGB values from the resources section and relying solely on the named colors, or ensure the fallback values accurately represent both appearance modes.

Suggested change

<namedColor name="SplashBackground">

<color red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>

</namedColor>

<namedColor name="SplashLogoColor">

<color red="0.066999999999999993" green="0.070999999999999994" blue="0.078" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>

</namedColor>

Copilot · 2025-12-01T11:02:31Z

V2er/LaunchScreen.storyboard

+        </scene>
+    </scenes>
+    <resources>
+        <image name="SplashLogo" width="1024" height="1024"/>


The storyboard hardcodes the image dimensions as 1024x1024 in the resources section (line 43), but the imageView is constrained to 100x100 points (lines 24-25). While Auto Layout will handle the scaling at runtime using the scaleAspectFit content mode (line 20), the hardcoded dimensions in the resources section are merely informational for Interface Builder.

This is acceptable, but be aware that providing a 1024x1024 PNG for display at 100x100 points means:

On 1x devices: The image is scaled down 10.24x

On 2x devices: The image is scaled down 5.12x

On 3x devices: The image is scaled down 3.41x

This is inefficient in terms of bundle size. Consider using appropriately sized assets or a vector PDF to optimize the app bundle.

Suggested change

<image name="SplashLogo" width="1024" height="1024"/>

<image name="SplashLogo" width="100" height="100"/>

Copilot · 2025-12-01T11:02:31Z

V2er/Assets.xcassets/SplashLogo.imageset/Contents.json

+      "filename" : "splash_logo.png",
+      "idiom" : "universal",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "3x"


The image asset is configured to use only a 1x image (splash_logo.png at 1024x1024) without providing 2x and 3x variants. While the preserves-vector-representation property is set to true (suggesting vector/PDF support), the actual asset is a PNG file, not a vector format.

For optimal display quality on all iOS devices, consider either:

Providing @2x and @3x PNG variants (2048x2048 and 3072x3072), or

Using a PDF vector format with preserves-vector-representation: true to automatically scale to all resolutions

Since the logo is used as a template (for tinting), a PDF vector would be the preferred approach for best quality and smaller bundle size.

Suggested change

"filename" : "splash_logo.png",

"idiom" : "universal",

"scale" : "1x"

},

{

"idiom" : "universal",

"scale" : "2x"

},

{

"idiom" : "universal",

"scale" : "3x"

"filename" : "splash_logo.pdf",

"idiom" : "universal"

Copilot · 2025-12-01T11:02:32Z

V2er/LaunchScreen.storyboard

@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="22505" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" launchScreen="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="01J-lp-oVM">
+    <device id="retina6_12" orientation="portrait" appearance="light"/>


[nitpick] The storyboard references a hardcoded device size (retina6_12 with 393x852 dimensions) which represents iPhone 14 Pro. While Auto Layout constraints are used (which is good), the hardcoded device reference in line 3 is just for Interface Builder preview purposes and won't affect runtime behavior on different devices.

However, it would be better practice to test on multiple device sizes to ensure the constraints work as expected across all supported iOS devices.

Suggested change

<device id="retina6_12" orientation="portrait" appearance="light"/>

github-actions · 2025-12-01T11:08:12Z

Code Coverage Report ❌

Current coverage: 29.73%

- Remove hardcoded RGB color values from storyboard resources section - Use named color references only (SplashBackground, SplashLogoColor) - Update image resource dimensions to match display size (100x100) - Simplify image asset configuration (single universal image) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-12-01T11:24:40Z

Code Coverage Report ❌

Current coverage: 24.53%

- Replace LaunchScreen.storyboard with SwiftUI SplashView - Add vector PDF logo from Android project for better scaling - Support light/dark mode with adaptive colors - Add TypewriterView with ease-out animation for slogan - Slogan: "Way to explore" with monospaced font - Logo size: 200x200, centered with slogan below 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Copilot · 2025-12-01T14:00:43Z

V2er/View/Splash/TypewriterView.swift

+    var easeIn: Bool = true
+
+    @State private var animatedText: AttributedString = ""
+    @State private var typingTask: Task<Void, Error>?


The task is typed as Task<Void, Error>? but never throws errors. Consider using Task<Void, Never>? to accurately reflect that this task doesn't throw, or add proper error handling for the async operations.

Suggested change

@State private var typingTask: Task<Void, Error>?

@State private var typingTask: Task<Void, Never>?

Copilot · 2025-12-01T14:00:44Z

V2er/View/Splash/SplashView.swift

+            DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) {
+                showSlogan = true
+            }
+
+            // Hide splash after animation completes
+            DispatchQueue.main.asyncAfter(deadline: .now() + 1.2) {
+                withAnimation(.easeOut(duration: 0.3)) {
+                    store.appState.globalState.launchFinished = true
+                }
+            }


Consider using the existing runInMain(delay:execute:) utility function instead of DispatchQueue.main.asyncAfter for consistency with the rest of the codebase. This pattern is used throughout the project (e.g., in Utils.swift, SearchPage.swift, Toast.swift).

Copilot · 2025-12-01T14:00:44Z

V2er/View/Splash/SplashView.swift

+            DispatchQueue.main.asyncAfter(deadline: .now() + 1.2) {
+                withAnimation(.easeOut(duration: 0.3)) {
+                    store.appState.globalState.launchFinished = true
+                }
+            }


Direct mutation of global state violates the Redux-like architecture pattern described in the project guidelines. State updates should be dispatched through actions and processed by reducers. Consider creating a GlobalActions.LaunchFinished action and dispatching it via the store instead.

github-actions · 2025-12-01T14:05:12Z

Code Coverage Report ❌

Current coverage: 31.45%

- Use runInMain utility instead of DispatchQueue.main.asyncAfter - Use LaunchFinishedAction and Redux pattern instead of direct state mutation - Change TypewriterView Task type from Task<Void, Error>? to Task<Void, Never>? since the task doesn't throw errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-12-01T14:13:17Z

Code Coverage Report ❌

Current coverage: 30.3%

Copilot AI review requested due to automatic review settings December 1, 2025 10:59

github-actions bot added the size/M label Dec 1, 2025

Copilot started reviewing on behalf of graycreate December 1, 2025 11:00 View session

Copilot finished reviewing on behalf of graycreate December 1, 2025 11:01

Copilot AI reviewed Dec 1, 2025

View reviewed changes

github-actions bot added size/M and removed size/M labels Dec 1, 2025

Copilot AI review requested due to automatic review settings December 1, 2025 13:58

github-actions bot added size/L and removed size/M labels Dec 1, 2025

Copilot started reviewing on behalf of graycreate December 1, 2025 13:58 View session

Copilot finished reviewing on behalf of graycreate December 1, 2025 14:00

Copilot AI reviewed Dec 1, 2025

View reviewed changes

github-actions bot added size/L and removed size/L labels Dec 1, 2025

graycreate merged commit ff8c91c into main Dec 1, 2025
6 checks passed

graycreate deleted the feature/splash-screen branch December 1, 2025 14:08

	<image name="SplashLogo" width="1024" height="1024"/>
	<image name="SplashLogo" width="100" height="100"/>

	@State private var typingTask: Task<Void, Error>?
	@State private var typingTask: Task<Void, Never>?

feat: add splash screen with centered logo #81

feat: add splash screen with centered logo #81

Uh oh!

Conversation

graycreate commented Dec 1, 2025

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 1, 2025

Code Coverage Report ❌

Uh oh!

github-actions bot commented Dec 1, 2025

Code Coverage Report ❌

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 1, 2025

Code Coverage Report ❌

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025

Code Coverage Report ❌

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants