From ffd8b5cd491dfefd1f9eee58b0e201c819e71e97 Mon Sep 17 00:00:00 2001 From: RelunSec Date: Tue, 30 Jun 2026 08:37:56 +0000 Subject: [PATCH 1/2] fix(factor): Correct comment --- src/uu/factor/src/factor.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/uu/factor/src/factor.rs b/src/uu/factor/src/factor.rs index 3f8cc93fb02..7c2a7119285 100644 --- a/src/uu/factor/src/factor.rs +++ b/src/uu/factor/src/factor.rs @@ -154,7 +154,8 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> { let print_exponents = matches.get_flag(options::EXPONENTS); let stdout = stdout(); - // We use a smaller buffer here to pass a gnu test. 4KiB appears to be the default pipe size for bash. + // We use a smaller buffer here to pass a GNU compatibility test. + // 4 KiB matches the standard block buffering size (BUFSIZ) used by GNU factor when writing to a pipe. let mut w = io::BufWriter::with_capacity(4 * 1024, stdout.lock()); if let Some(values) = matches.get_many::(options::NUMBER) { From 4834c02b5c9f72c03ff9152a8192ccf36ad93a4b Mon Sep 17 00:00:00 2001 From: RelunSec Date: Tue, 30 Jun 2026 08:44:32 +0000 Subject: [PATCH 2/2] Fix review issues Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com> --- src/uu/factor/src/factor.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/uu/factor/src/factor.rs b/src/uu/factor/src/factor.rs index 7c2a7119285..a06b42896eb 100644 --- a/src/uu/factor/src/factor.rs +++ b/src/uu/factor/src/factor.rs @@ -154,8 +154,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> { let print_exponents = matches.get_flag(options::EXPONENTS); let stdout = stdout(); - // We use a smaller buffer here to pass a GNU compatibility test. - // 4 KiB matches the standard block buffering size (BUFSIZ) used by GNU factor when writing to a pipe. + // use a smaller buffer here to pass a GNU test. let mut w = io::BufWriter::with_capacity(4 * 1024, stdout.lock()); if let Some(values) = matches.get_many::(options::NUMBER) {