address feedback

Author: nyurik

src/uu/checksum_common/src/lib.rs

@@ -5,6 +5,7 @@
 
 // spell-checker:ignore (ToDO) algo
 
+use std::borrow::Borrow;
 use std::ffi::OsString;
 
 use clap::builder::ValueParser;
@@ -159,7 +160,7 @@ pub fn checksum_main(
     let files = matches
         .get_many::<OsString>(options::FILE)
         .unwrap()
-        .map(OsString::as_os_str);
+        .map(Borrow::borrow);
 
     if check {
         // cksum does not support '--check'ing legacy algorithms

src/uu/cp/src/copydir.rs

@@ -111,7 +111,7 @@ impl<'a> Context<'a> {
         let root_path = current_dir.join(root);
         let target_is_file = target.is_file();
         let root_parent = if target.exists() && !root.to_str().unwrap().ends_with("/.") {
-            root_path.parent().map(Path::to_path_buf)
+            root_path.parent().map(ToOwned::to_owned)
         } else if root == Path::new(".") && target.is_dir() {
             // Special case: when copying current directory (.) to an existing directory,
             // we don't want to use the parent path as root_parent because we want to

src/uu/csplit/src/patterns.rs

@@ -196,7 +196,7 @@ mod tests {
     fn up_to_line_pattern() {
         let input: Vec<String> = vec!["24", "42", "{*}", "50", "{4}"]
             .into_iter()
-            .map(ToString::to_string)
+            .map(ToOwned::to_owned)
             .collect();
         let patterns = get_patterns(input.as_slice()).unwrap();
         assert_eq!(patterns.len(), 3);

src/uu/env/src/native_int_str.rs

@@ -257,7 +257,7 @@ impl<'a> NativeStr<'a> {
         let n_prefix = to_native_int_representation(prefix);
         let result = self.match_cow(
             |b| b.strip_prefix(&*n_prefix).ok_or(()),
-            |o| o.strip_prefix(&*n_prefix).map(<[_]>::to_vec).ok_or(()),
+            |o| o.strip_prefix(&*n_prefix).map(ToOwned::to_owned).ok_or(()),
         );
         result.ok()
     }
@@ -266,7 +266,7 @@ impl<'a> NativeStr<'a> {
         let n_prefix = to_native_int_representation(prefix);
         let result = self.match_cow_native(
             |b| b.strip_prefix(&*n_prefix).ok_or(()),
-            |o| o.strip_prefix(&*n_prefix).map(<[_]>::to_vec).ok_or(()),
+            |o| o.strip_prefix(&*n_prefix).map(ToOwned::to_owned).ok_or(()),
         );
         result.ok()
     }