Update utopia-php/span to 3.0#49
Merged
Merged
Conversation
Migrate the three breaking API changes from span 1.1 to 3.0:
- addExporter() was removed; use the variadic setExporters() instead.
- finish() now sets the `level` attribute itself, so the previous
$span->set('level', 'warn') calls would be clobbered. Track the level
through onPacket() and pass it via finish($level).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR upgrades
Confidence Score: 5/5Straightforward dependency upgrade with two targeted call-site changes; all early-return paths correctly reach Both breaking-change migrations are minimal and correctly placed. The No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Update utopia-php/span to 3.0" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
utopia-php/spanfrom1.1.*to3.0.*(resolves to 3.0.1) and migrates the breaking API changes.Breaking changes migrated
Span::addExporter()removed → replaced with the variadicSpan::setExporters(...)(tests/resources/server.php).finish()now owns thelevelattribute → it setslevelitself (from error presence, or an optionalfinish(?string $level)argument), so the old$span->set('level', 'warn')calls would be silently clobbered.onPacket()now tracks the level in a variable and passes it through as$span->finish($level)(src/DNS/Server.php).Verification
docker compose).{"level":"info","action":"dns.worker.start",...}.🤖 Generated with Claude Code