Skip to content

Re-force internal attribute selection#585

Merged
abnegate merged 2 commits into
mainfrom
feat-select-internals
May 21, 2025
Merged

Re-force internal attribute selection#585
abnegate merged 2 commits into
mainfrom
feat-select-internals

Conversation

@abnegate

@abnegate abnegate commented May 14, 2025

Copy link
Copy Markdown
Member

Because without them:

  • It breaks select queries in all statically typed SDKs,
  • There are many places we need them internally
  • Select queries meant to be for choosing what of your data you want, regardless of internals
  • They add <1KB of data, negligible in almost all scenarios

@abnegate abnegate requested a review from fogelito May 14, 2025 14:23
Comment on lines +1687 to +1693
$internalKeys = [
'$id',
'$internalId',
'$permissions',
'$createdAt',
'$updatedAt',
];

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using the const because we don't want collection or tenant here

Comment thread src/Database/Adapter/SQL.php
Comment thread src/Database/Database.php Outdated
Comment thread tests/e2e/Adapter/Scopes/DocumentTests.php
Comment thread src/Database/Adapter/SQL.php
@abnegate abnegate merged commit e97cc6b into main May 21, 2025
14 checks passed
@abnegate abnegate deleted the feat-select-internals branch May 21, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants